Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to get lineage metadata from Oracle source when add_database_name_to_urn is set to False (default value) #11677

Open
amirulmenjeni opened this issue Oct 21, 2024 · 1 comment
Labels
bug Bug report

Comments

@amirulmenjeni
Copy link

Describe the bug
When ingesting metadata using the Oracle source, I get the "invalid view identifier" warning. Looking at the source code where this warning was issued, this causes the method to return without running any parsing at all to get the lineage metadata. The culprit is likely the get_db_schema that expects the dataset_identifier parameter to include the database name (i.e., database_name.schema_name.view_name instead of just schema_name.view_name).

Setting add_database_name_to_urn to True fix this issue.

This might be the expected behavior and not a bug. In that case it'd probably be good if this behavior is mentioned in the Oracle source docs.

To Reproduce
Steps to reproduce the behavior:

  1. Create a simple Oracle source recipe (e.g., oracle_recipe.yml)
  2. Set add_database_name_to_urn to True (the default)
  3. Run the ingestion (datahub ingest -c oracle_recipe.yml)

Expected behavior
When add_database_name_to_urn is set to False, the lineage parsing should still be successful. The add_database_name_to_urn should not affect whether or not the lineage is extracted or not.

Screenshots
If applicable, add screenshots to help explain your problem.

Not really applicable.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Edge
  • Version: Version 129.0.2792.89 (Official build) (64-bit)

Additional context
Add any other context about the problem here.

None to add.

@amirulmenjeni amirulmenjeni added the bug Bug report label Oct 21, 2024
@amirulmenjeni amirulmenjeni changed the title Invalid view identifier when ingesting from Oracle source without database name in URN Failed to get lineage metadata from Oracle source when add_database_name_to_urn is set to False (default value) Oct 21, 2024
@mcbenzing
Copy link

Maybe this helps:

#11777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants