-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bbox better name than bounds ? #4
Comments
Initially, I used bbox, but I used bounds for more general features. I implemented the control with a polygon object here : https://github.com/datagistips/geo4TableSchema/blob/main/mds/BATCH-EXAMPLES.md#bounds The questions are
|
Thx, I get it a bit better now.
I do not have a strong opinion on this. When would you want to test it against an other extend than the bbox ?
If |
ok
geovalidate needs that the source data and control bounds are in the same CRS because the CRS of source data must be the CRS specified in the
There can be cases where you want to control your data against a specific polygon : "is my data which focuses on Aix-en-Provence building IDs contained in Aix-en-Provence city contour ?" But the problem is that it can make the json heavy.. So, it should be better to relate to an external resource. For instance, a reference geojson, like a BDTOPO one provided in the data package, or on a web server, or via an API, against which to control data. I don't know if this kind of "remote" or external file control relationship is implemented in TableSchema. It would be nice to ask the question. What's your opinion on that ? Something like : {
"bounds":{
"resources":[
{
"title":"myCity",
"path":"http://reference-data/mycity.json"
}
]
}
} What's your opinion on this ?
Ok for |
No idea on geoCSV, I assumed it was like geojson with a default CRS. Well I understand the problem a bit better now thx! I can see the pros of having a I will play the devil advocate (that doesn't means I am against the idea). Two sides notes (if you want I can open new issues to make it cleaner). |
Hello,
I think
bbox
is more common and better name for bounding box.Maybe I miss the logic behind having a different name (but it look like a a bbox here: https://github.com/datagistips/geo4TableSchema/blob/main/f_geovalidate.py#L28-L43) if so it could be clarified.
The text was updated successfully, but these errors were encountered: