New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Check: While validating StatVar check against schema in KG or local MCF #31

Open

pradh opened this issue Aug 20, 2021 · 1 comment

Assignees

Contributor

pradh commented Aug 20, 2021 •

edited

Loading

We should do the following checks:

Ensure every enum, property, class reference exists
Ensure properties used in measuredProperty and as constraintProperties have domainIncludes set to the populationType
Ensure enums used as values in properties have their class set as rangeIncludes of the property

pradh self-assigned this

pradh added the in progress label

Contributor Author

pradh commented Aug 27, 2021

Part of it has been implemented in existence-checks.

Notably missing are checking for domainIncludes and rangeIncludes for constraintProperties, which is in turn blocked on the TODO here:

import/util/src/main/java/org/datacommons/util/McfMutator.java

Line 27 in 2040186

// TODO: Implement constraintProperties computation for SV (CPP Parity).

pradh removed the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment