-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup MegaBlocks
Installation
#126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I addressed all of your comments @b-chu. I based my My fork of LMK if that sounds good to you. |
Are we ready to merge? Any other reviewers we should notify? |
Tagging @mvpatel2000 for the review before we merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wanted to note that since this PR includes a pyproject.toml
, I think it enables build isolation which may make the package more difficult to install. Since the torch dep is specified in pyproject.toml it should be ok, but upgrading to latest torch versions will need to be done with care.
Currently using custom forks of packages to resolve installation issues:
Blocked until these are merged. @dakinggg |
Closing this PR since #127 changed a lot of things. |
Update 2024-07-25:
stk
for now and not my fork. We'll take care of this in a separate PR._version.py
for versioning and we dynamically read the version insetup.py
.This PR cleans up the
MegaBlocks
installation process. Specifically, itpyproject.toml
fileREADME.md
installation instructions.gitignore
setup.py
, i.e.torch
andnumpy
megablocks[dev]
, i.e.coverage
,pytest
,pytest_codeblocks
,pytest-cov
,pre-commit
.torch
while runningsetup.py
setup.py
: replade'
with"
and add license headerlong_description
by parsingREADME.md
better (taken fromcomposer
)MegaBlocks
depends onstk
.stk
'ssetup.py
unnecessarily imports torch which causes issues with installingstk
before we havetorch
installed. We now install my fork ofstk
that fixes this issue while waiting for @tgale96 to merge my PR fixing this instk
.