From 688af35ce60b16bded8e53bb91b24aab0878cf1a Mon Sep 17 00:00:00 2001 From: Domenico Corvasce Date: Wed, 20 Dec 2023 23:11:11 +0100 Subject: [PATCH] Remove changes reversed to a future pull request --- bundle/config/mutator/process_target_mode_test.go | 12 ------------ bundle/config/target.go | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/bundle/config/mutator/process_target_mode_test.go b/bundle/config/mutator/process_target_mode_test.go index af2f48434b..bb3c38af5b 100644 --- a/bundle/config/mutator/process_target_mode_test.go +++ b/bundle/config/mutator/process_target_mode_test.go @@ -179,18 +179,6 @@ func TestProcessTargetModeDevelopmentCustomResourceNamePrefix(t *testing.T) { assert.Equal(t, "staging__us_east_1_registeredmodel1", b.Config.Resources.RegisteredModels["registeredmodel1"].Name) } -func TestProcessTargetModeDevelopmentCustomDeploymentTag(t *testing.T) { - b := mockBundle(config.Development) - b.Config.Bundle.ResourceNamePrefix = "custom" - - m := ProcessTargetMode() - err := bundle.Apply(context.Background(), b, m) - require.NoError(t, err) - - // Job 1 - assert.Equal(t, "[custom] job1", b.Config.Resources.Jobs["job1"].Name) -} - func TestProcessTargetModeDevelopmentTagNormalizationForAws(t *testing.T) { b := mockBundle(config.Development) b.Tagging = tags.ForCloud(&sdkconfig.Config{ diff --git a/bundle/config/target.go b/bundle/config/target.go index f8e9075631..7366aa6d5f 100644 --- a/bundle/config/target.go +++ b/bundle/config/target.go @@ -50,7 +50,7 @@ type Target struct { const ( // Development mode: deployments done purely for running things in development. - // Any deployed resources will be marked as "dev" (or custom a `tag`) and might be hidden or cleaned up. + // Any deployed resources will be marked as "dev" and might be hidden or cleaned up. Development Mode = "development" // Production mode: deployments done for production purposes.