Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating attributes outside of __init__ #100

Closed
hardbyte opened this issue Apr 13, 2018 · 2 comments
Closed

Creating attributes outside of __init__ #100

hardbyte opened this issue Apr 13, 2018 · 2 comments
Assignees
@nbgl
Labels
bug
Milestone
Sprint 2018-05-07

Comments

@hardbyte
Copy link
Collaborator

From #96:

I prefer not to create new attributes in methods outside init, eg. randomnames.load_names creates self.all_male_first_names etc. (ie. give them the value None in __init__).
@hardbyte hardbyte added the bug label Apr 13, 2018
@hardbyte hardbyte mentioned this issue Apr 13, 2018
Open
@nbgl nbgl added this to the Sprint 2018-05-07 milestone May 8, 2018
@nbgl nbgl mentioned this issue May 8, 2018
Merged
@nbgl
Copy link
Contributor

nbgl commented May 8, 2018

I’ve only saw this occur in randomnames.NameList. That is fixed in #146. Please let me know if I’ve missed any others.

@nbgl
Copy link
Contributor

nbgl commented May 11, 2018

Closed by #146.

@nbgl nbgl closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbgl nbgl

Labels
bug
Projects
None yet
Milestone
Sprint 2018-05-07
Development

No branches or pull requests
2 participants
@hardbyte @nbgl