Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to separate the end-of-report notes from inspections' final citations #58

Open
jsvine opened this issue Apr 10, 2023 · 1 comment
Open

Figure out how to separate the end-of-report notes from inspections' final citations #58

jsvine opened this issue Apr 10, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jsvine
Copy link
Contributor

jsvine commented Apr 10, 2023

In data/combined/inspections-citations.csv, narrative for the final citation of each inspection also contains the inspection report's end-of-report text. Those notes are semi-consistent, semi-not. Until we can figure out a reliable way to separate the end-of-report text from the final citation's actual text, I'd rather err on the side of caution (i.e., not stripping anything out). But perhaps we can find a way to consistently separate those parts?

See discussion in #56 (comment) and the comments that follow.
@jsvine jsvine added enhancement New feature or request help wanted Extra attention is needed labels Apr 10, 2023
@jsvine
Copy link
Contributor Author

jsvine commented May 11, 2023

Adding a comment here to note that there's some related progress in PR #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsvine