Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default helm liveness probe timeout (1s) is too short #917

Open
bnaul opened this issue Oct 29, 2024 · 1 comment · May be fixed by #918
Open

Default helm liveness probe timeout (1s) is too short #917

bnaul opened this issue Oct 29, 2024 · 1 comment · May be fixed by #918
Labels
bug good first issue help wanted operator

Comments

@bnaul
Copy link
Contributor

bnaul commented Oct 29, 2024

After running helm install --repo https://helm.dask.org dask-kubernetes-operator dask-kubernetes-operator --create-namespace -n dask-operator, my dask-operator pod is continually being restarted due to failing the liveness probe: it seems like in practice it takes between 1 and 2s to respond. Patching the deployment and overriding the timeout to 5s resolved the issue.

Maybe the probe timeout could be made configurable in the helm template?
@jacobtomlinson
Copy link
Member

Making that configurable would be great.

@bnaul bnaul linked a pull request Oct 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add configurable liveness probe timeout replicahq/dask-kubernetes
2 participants
@bnaul @jacobtomlinson