Fix CI failing tests #416
Merged
Fix CI failing tests #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszo
force-pushed
the
python_versions
branch
5 times, most recently
from
ced80bb
to
e3e4709
Compare
lukaszo
force-pushed
the
python_versions
branch
from
e3e4709
to
e281312
Compare
|
Even though I've removed it, it looks like it's still waiting for the 3.8 test to finish. Maybe it's some kind of protection as I'm not a member of the team, but I'm modifying the CI 🤷♂️ |
|
Ok, it seems that the test for 3.8 is marked in |
|
Hi @jacobtomlinson Will you have a time to check this out? |
jacobtomlinson
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Sorry for the delay in reviewing here. This looks great. At some point I would like to explore dropping pytest-asyncio in favour of pytest-anyio with just the asycnio backend as we have done in other parts of Dask, but in the meantime this gets things going.
I'll change the branch protection rules accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like CI currently fails because of three reasons:
There are two ways to fix it. Switch back to using auto mode or replace all
@pytest.fixturewith@pytest_asyncio.fixtureIn this PR I've used the first option. If you prefer the second option, I will update the PR.
When creating conda env for 3.8 it fails with the following error message:
ERROR: Package 'dask' requires a different Python: 3.8.18 not in '>=3.9'To fix it, I've removed python3.8 and updated all examples to use 3.9
Updated.