-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulate in-place operators like +=
by replacing _meta
#500
Comments
You would need to change the meta, the graph and the node key (.name), I think. |
Yes, Martin is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Like scikit-hep/awkward#3084, there's been a request to allow
dask_array += something
by replacing the content of thedask_array
. For example,raises
which is confusing to users. If
dask_awkward.Array
hadand similar, then
one += two
would changeone
in place. I'm told thatdask.array
and dask-histogram already do this.The implementation I've suggested above, in which dask-awkward replaces its
_meta
in__iadd__
, is a little different from what I'm planning for Awkward (scikit-hep/awkward#3084), which would replace itslayout
. Maybe there are bad consequences, like losing typetracer reports. Can a_meta
change in place? Maybe it would be better to do this:after scikit-hep/awkward#3084 has been implemented.
The text was updated successfully, but these errors were encountered: