Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart test with --pause-after-load flag does not print DevTools URI #55674

Closed
kenzieschmoll opened this issue May 8, 2024 · 6 comments
Closed
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@kenzieschmoll
Copy link
Contributor

dart test test/nested/simple_test_1.dart --pause-after-load
Resolving dependencies in `/Users/kenzieschmoll/develop/devtools/packages/devtools_extensions/example/app_that_uses_foo`...
Downloading packages...
Got dependencies in `/Users/kenzieschmoll/develop/devtools/packages/devtools_extensions/example/app_that_uses_foo`.
Building package executable... (6.5s)
Built test:test.
00:01 +0: loading test/nested/simple_test_1.dart

Observatory URL: http://127.0.0.1:58787/zPMwLkxnluk=/#/inspect?isolateId=isolates%2F6734125496635939&objectId=libraries%2F%4018483025
The test runner is paused. Open the Observatory and set breakpoints. Once you're finished, return to this terminal and
press Enter.

Opening the observatory URI shows this:
Screenshot 2024-05-08 at 10 39 47 AM

@jakemac53 @bkonyi

@jakemac53
Copy link
Contributor

@natebosch can you look at this one?

@natebosch natebosch self-assigned this May 9, 2024
@bkonyi
Copy link
Contributor

bkonyi commented May 10, 2024

FYI, this is related to dart-lang/test#2185

@natebosch
Copy link
Member

From the linked issue it looks like there is some required work in dart test. Have we verified that dart test is capable of serving dev tools?

@mraleph mraleph added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label May 11, 2024
@bkonyi
Copy link
Contributor

bkonyi commented May 14, 2024

From the linked issue it looks like there is some required work in dart test. Have we verified that dart test is capable of serving dev tools?

Looks like that wasn't covered by the migration to launch DDS from the VM service instead of DartDev. This CL should resolve that: https://dart-review.googlesource.com/c/sdk/+/366560.

@aam aam added P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels May 15, 2024
@a-siva a-siva added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 31, 2024
@a-siva
Copy link
Contributor

a-siva commented Jul 31, 2024

Looks like this is fixed and the pending work for pkg:test is being tracked in dart-lang/test#2185

@a-siva a-siva closed this as completed Jul 31, 2024
@bkonyi
Copy link
Contributor

bkonyi commented Jul 31, 2024

SDK fix landed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Development

No branches or pull requests

7 participants