Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should support retries #65

Open
sigurdm opened this issue Mar 7, 2019 · 2 comments
Open

We should support retries #65

sigurdm opened this issue Mar 7, 2019 · 2 comments
Labels
package:gcloud type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Mar 7, 2019

We should (optionally) retry queries that fail with HTTP 5xx and 429 response codes using truncated exponential backoff.

https://cloud.google.com/storage/docs/exponential-backoff outlines how it should be implemented
@jonasfj
Copy link
Member

jonasfj commented Apr 5, 2019

Specifically for 500 and 503:
https://cloud.google.com/storage/docs/xml-api/reference-status#500internal-server-error

Probably not for 429... I think that's only likely to make things worse..

@jonasfj jonasfj added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Apr 5, 2019
@jonasfj jonasfj mentioned this issue Jun 17, 2019
Closed
@jonasfj
Copy link
Member

jonasfj commented Jun 17, 2019

We can probably just wrap the http.Client return from authClientService with package:http_retry.

As long as we only retry:

  • 429 (maybe with a slightly longer delay)
  • 504
  • 500
  • 503

See:

@devoncarew devoncarew transferred this issue from dart-archive/gcloud Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:gcloud type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonasfj @devoncarew @sigurdm