Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket.write() should retry non-resumable uploads too #63

Open
jonasfj opened this issue Nov 6, 2018 · 1 comment
Open

Bucket.write() should retry non-resumable uploads too #63

jonasfj opened this issue Nov 6, 2018 · 1 comment

Comments

@jonasfj
Copy link
Member

jonasfj commented Nov 6, 2018

As I've come to understand it there is some special code handling resumable uploads in googleapis package...

We should ensure that the same retry strategy is employed when doing non-resumable uploads in:
https://github.com/dart-lang/gcloud/blob/fbe7ef67f9234e2af00c18db6996c08f26a006ee/lib/src/storage_impl.dart#L595

@jonasfj
Copy link
Member Author

jonasfj commented Nov 6, 2018

After further investigation it seems things are not as simple, resumable uploads are only retried if it's not the first request initiating the resumable upload process.

Effectively, it seems retries are only attempted if uploading have been initiated..

I don't think we should fix this now, as there doesn't seem to be a clear policy on what we retry and when..

@devoncarew devoncarew transferred this issue from dart-archive/gcloud Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants