Translate error messages from auth.js

[stephanvierkant]

In #22 I've added a Dutch translation for one single message ('press button').

However, I didn't translate the error messages (yet): https://github.com/darookee/u2f-two-factor-bundle/blob/master/Resources/public/js/auth.js#L10

What's the best way to translate error messages in a Javascript file? I know how translations in Symfony/Twig work, but I'm not sure what's the best way to translate strings from a Javascript files.

[darookee]

I'm not aware of any best practices for translating string ins JS files in a symfony environment, but this bundle looks promising. But using it would add another dependency to this bundle...

[stephanvierkant]

Using a bundle to translate just a couple of short error messages seems somehow overkill to me.

Maybe we should do something like this:

<script type="text/javascript">
    var translations = {
       // ... 
       'yes' : {{ 'yes' | trans }},
       // ...
    }
</script>

Stolen from https://stackoverflow.com/questions/6940433/what-is-the-best-way-to-translate-javascript-literal-strings-in-assetic-assets/42175123

[darookee]

Yes, that sounds reasonable.

[stephanvierkant]

Let's pick this up together with #25.

I think we should translate the types, not the codes:

https://github.com/grantila/u2f-api#user-content-errors or https://developers.yubico.com/U2F/Libraries/Client_error_codes.html

OK = 0 // u2f-api will never throw errors with this code
OTHER_ERROR = 1
BAD_REQUEST = 2
CONFIGURATION_UNSUPPORTED = 3
DEVICE_INELIGIBLE = 4
TIMEOUT = 5

[darookee]

Yes, that's a good idea. I'll look into #25 and #26 as soon as I can.