Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker not sampling exact colour under crosshairs in Color Equalizer module #17851

Open
europlatus opened this issue Nov 18, 2024 · 0 comments

Comments

@europlatus
Copy link

Describe the bug

I'm not sure how the colour samples are calculated using the color picker in the Color Equalizer module, but it doesn't seem to be accurate to the crosshairs. Perhaps it is calculating an average of the whole circle, but it still seems to have an offset.

In this example of a RAW file at 100% zoom, the crosshairs are clearly over the yellow colour, and the majority of the circle is also over the yellow colour, but the sample colour is a dark grey.

image

Should the sampled colour be directly under the crosshairs? This would be ideal.
If the current behaviour is as designed, could the weighting be adjusted to more accurately reflect the colour that the circle is mostly covering (e.g. yellow in the sample image above)?

Steps to reproduce

  • Open an image file.
  • Enable Color Equalizer, then click on the colour picker.
  • Sample a color near another colour and move the reticle around to see how the sample colour changes under the crosshairs

Expected behavior

As there is already an "area select" mode for the colour picker, I think the crosshairs should be highly accurate for picking a hue. If this can't be done for some reason, the sample colour should more accurately reflect the colour that the crosshairs are hovering over.

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.8.0

What OS are you using?

Windows

What is the version of your OS?

Windows 10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant