Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix packaging approach #245

Closed
D3vil0p3r opened this issue Aug 21, 2023 · 0 comments
Closed

[Bug] Fix packaging approach #245

D3vil0p3r opened this issue Aug 21, 2023 · 0 comments

Comments

@D3vil0p3r
Copy link

setup.cfg calls requirements.txt that mixes both runtime and build dependencies.

This approach must be improved because there is no need to have build dependencies installed at runtime. On the packaged version of the tool this approach generates issues.

You can solve this in two manners:

  1. Create two separated requirements files: one for build deps requirements-dev.txt (pytest and flake8) and another one for runtime deps requirements.txt (the remaining deps in requirements.txt) and change setup.cfg according to this doc by specifying the requirement file for the build system and the one for the runtime system.
  2. Better solution: to drop the obsolete setup.py anyway and migrate to pyproject.toml that offers more flexibility cf. https://python-poetry.org/docs/master/managing-dependencies/

Ref: BlackArch/blackarch#3940

D3vil0p3r added a commit to D3vil0p3r/blackarch that referenced this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant