Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for seconds #1

Open
LukasAnda opened this issue Feb 29, 2024 · 4 comments
Open

Add support for seconds #1

LukasAnda opened this issue Feb 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@LukasAnda
Copy link

Hey, thanks for porting this library to compose multiplatform! I was wondering, I'm making a stopwatch/timer app, would it be possible to have seconds in the spinner as well? Or could I somehow even help implementing that?

@darkokoa
Copy link
Owner

darkokoa commented Feb 29, 2024

Hi, I'm happy to add this feature. Do you think about how it should be implemented? 🤔

Here are 3 things to consider:

  1. Should seconds be optional, or required by default?
  2. How will the time picker's / datetime picker's width be affected by adding seconds?
  3. Should the padding between elements in the time picker / datetime picker be reduced to accommodate adding seconds?

@LukasAnda
Copy link
Author

Hey I'm sorry for taking so long to get back to you.

  1. I think it should be passed as an argument (maybe based on the format, so I can choose even to display Hours:seconds or minutes:seconds for whatever reason)
  2. Well it should wrap the width anyway no?
  3. Hmm maybe provide a modifier/ContentPadding to be able to change this during runtime?

@darkokoa
Copy link
Owner

darkokoa commented Mar 6, 2024

OK. For now the picker can not set date and time formats, I will temporarily use HH:MM:SS for the time format.

@darkokoa darkokoa added the enhancement New feature or request label Mar 6, 2024
@LukasAnda
Copy link
Author

Sure, that works for me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants