Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any V1 forks that support Django 3x? #781

Open
yigitguler opened this issue Jun 2, 2021 · 16 comments
Open

Any V1 forks that support Django 3x? #781

yigitguler opened this issue Jun 2, 2021 · 16 comments

Comments

@yigitguler
Copy link

Hi,

Are there any version 1 forks that support Django 3.1 or 3.2? It was a great project, it can be good to list maintained forks here.

@tjerkw
Copy link

tjerkw commented Jun 11, 2021

If you follow this thread: #475 (comment)
And especially this comment:
#475 (comment)

You can see that @mhindery created a fork of V1 with some fixes for Django 3:

https://github.com/mhindery/django-suit/tree/develop

I didnt try it, but maybe we can all start using it, and add fixes to it?

@tjerkw
Copy link

tjerkw commented Jun 11, 2021

@darklow can you hand over this project? Or are you ok with us forking it?

@yigitguler
Copy link
Author

Thank you @tjerkw. If we see any issues or improvement chances, we will open PRs to @mhindery's fork.

@pulse-mind
Copy link

For your information, on my fork v2 I made e'w commits
I am working on Bootstrap 5.1 branch too

@darklow
Copy link
Owner

darklow commented Dec 24, 2021

I can easily run Django 3.x with following fixes:
#763 (comment)

@mheijink
Copy link

For your information, on my fork v2 I made e'w commits I am working on Bootstrap 5.1 branch too

Hi pulse-mind, can you adjust your fork so it also support Django 4 ?

@pulse-mind
Copy link

For your information, on my fork v2 I made e'w commits I am working on Bootstrap 5.1 branch too

Hi pulse-mind, can you adjust your fork so it also support Django 4 ?

Yes, I will do it, but I always wait a little bit when a new release is coming.

@mhindery
Copy link

I'll also try to get my fork working with the 4.x changes (since we use it at my company and like to upgrade fast, it should be on the short term timeline)

@pulse-mind
Copy link

I just pushed a new branch for v4 "django40". Tests on local are ok. I added github workflow...

@pulse-mind
Copy link

It looks good and it should works also with django v3. The migration is very light to have it working on Django v4

@pulse-mind
Copy link

@mhindery
I've done the pull request + merge on my V2 branch.
It works with Django 3 and Django 4.

@Elger9
Copy link

Elger9 commented Jan 31, 2023

It works with Django 3 and Django 4.

Hi, thanks for the fork for Django Suit for Django 3x and 4x. I am just trying it https://github.com/pulse-mind/django-suit/tree/v2 with Django 3.2.16 LTS - installed nicely. However, I noticed a bug. I don't have the green 'Add modelname' button next to my models in change list view. It looks like there is no 'toolbar' div. The button appears next to models from Django ie auth.user or auth.group. Have you encountered this problem? Greetings.

@pulse-mind
Copy link

@Elger9 Did you try the demo of this version ?
I suggest you to run the demo on your PC to check if these problems appear also on the demo ;). Let me know.

@Elger9
Copy link

Elger9 commented Jan 31, 2023

Thanks for the fast reply. The solution was simple. You need to define search_fields in class admin.ModelAdmin. Then the appropriate layer in HTML is attached, where the add button is.

By the way, it would be nice if the author would add commits from your fork to base repo.

@pulse-mind
Copy link

The author is working on some other things and does not maintain anymore his repo. I think he does not want to be responsible and spend time on that, I can understand !
Have a good day.

@Elger9
Copy link

Elger9 commented Jan 31, 2023

Thanks for the clarification, have a nice day as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants