Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players with a full inventory do not receive cumulative rewards #54

Open
UnknownSilicon opened this issue Jan 16, 2022 · 0 comments
Open

Comments

@UnknownSilicon
Copy link

Just as the title says, if a player's inventory is full when they are supposed to receive a cumulative reward. This is due to VotesListener#onReceive returning if the player's inventory is full

return sendMessage(party.manager().getCommandIssuer(online), Messages.VOTES__INVENTORY_FULL)

while the only place the cumulative handlers are called is in this function. Though the cumulative handlers will be called during the next vote, they will not trigger rewards since they require exact values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant