Api version guide #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
|
Please make sure that this is reviewed by both runtime maintainers and SDK maintainers as this also impacts all SDK maintainers. |
|
cc @dapr/maintainers-java-sdk @dapr/maintainers-go-sdk @dapr/maintainers-dotnet-sdk @dapr/maintainers-js-sdk @dapr/maintainers-python-sdk @dapr/maintainers-dapr |
artursouza
previously approved these changes
May 17, 2023
|
+1 binding |
Signed-off-by: Mukundan Sundararajan <[email protected]>
mukundansundar
dismissed stale reviews from artursouza and daixiang0
via
4801ef8
Signed-off-by: Mukundan Sundararajan <[email protected]>
shubham1172
reviewed
Aug 17, 2023
| - [ ] Minimum of N (three?) implementations of this building block | ||
| - [ ] Certification tests for implementations | ||
| - [ ] Conformance tests exercise both positive and negative cases | ||
| - [ ] Minimum of N (three?) implementations of this building block |
There was a problem hiding this comment.
Should we keep this three or is it a TBD?
There was a problem hiding this comment.
Good call out, this should be decided. IMO 3 is reasonable.
shubham1172
reviewed
Aug 17, 2023
Comment on lines
+74
to
+76
| - [ ] Change API version to stable. See [Stable API Versioning](../guides/api-design.md#progression-of-api-version-to-stable) | ||
| - [ ] HTTP `v1.0-suffix` to `v1.0` | ||
| - [ ] gRPC `MethodSuffix` to `Method` |
There was a problem hiding this comment.
Should this be also added to beta? Change alpha suffix to beta?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23