-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: enhanced configuration example #483
Conversation
Signed-off-by: sadath-12 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 35 35
Lines 2841 2841
=======================================
Hits 1991 1991
Misses 738 738
Partials 112 112 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this moving towards no time dependency where possible, but it could also be argued that this is a form of validation to ensure that there are no excessive waits.
The mechanical markdown validation hasn't been updated for your revision.
I'm not too sure on the verbiage change being any better than previously. I'd like to see the "with" prefix removed back to the original state
Hmm yeah , also making sure whatever we are passing we are getting it back correctly whereas before the information retrieved was missing from what's sent. |
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Eliminated
time.sleep
withsync.WaitGroup
soSubscribeConfigurationItems
can take proper time to finish and also updated to more appropriate logs