Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: enhanced configuration example #483

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Conversation

sadath-12
Copy link
Contributor

Eliminated time.sleep with sync.WaitGroup so SubscribeConfigurationItems can take proper time to finish and also updated to more appropriate logs

@sadath-12 sadath-12 requested a review from a team as a code owner December 14, 2023 18:51
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f7b59) 70.08% compared to head (fc925ed) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files          35       35           
  Lines        2841     2841           
=======================================
  Hits         1991     1991           
  Misses        738      738           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this moving towards no time dependency where possible, but it could also be argued that this is a form of validation to ensure that there are no excessive waits.

The mechanical markdown validation hasn't been updated for your revision.

I'm not too sure on the verbiage change being any better than previously. I'd like to see the "with" prefix removed back to the original state

@sadath-12
Copy link
Contributor Author

sadath-12 commented Dec 23, 2023

I agree with this moving towards no time dependency where possible, but it could also be argued that this is a form of validation to ensure that there are no excessive waits.

The mechanical markdown validation hasn't been updated for your revision.

I'm not too sure on the verbiage change being any better than previously. I'd like to see the "with" prefix removed back to the original state

Hmm yeah , also making sure whatever we are passing we are getting it back correctly whereas before the information retrieved was missing from what's sent.

Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0 daixiang0 merged commit d5ffe77 into dapr:main Dec 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants