Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify local Golangci-lint version with GitHub actions #454

Closed
sicoyle opened this issue Sep 21, 2023 · 2 comments · Fixed by #467
Closed

Verify local Golangci-lint version with GitHub actions #454

sicoyle opened this issue Sep 21, 2023 · 2 comments · Fixed by #467
Assignees
Labels
enhancement New feature or request

Comments

@sicoyle
Copy link
Contributor

sicoyle commented Sep 21, 2023

Is your feature request related to a problem? Please describe.
We should have tooling to verify that the linter installed locally matches that of the Github actions to prevent confusion for contributors and issues showing up in CI that do not occur locally due to mismatching versions.

Describe the solution you'd like
A similar solution to that of the components contrib repo solution here: https://github.com/dapr/components-contrib/pull/1861/files

Describe alternatives you've considered
None

Additional context
Reference issue: dapr/cli#1052
Inspiration for solution: https://github.com/dapr/components-contrib/pull/1861/files

@sicoyle sicoyle added the enhancement New feature or request label Sep 21, 2023
@mikeee
Copy link
Member

mikeee commented Oct 10, 2023

/assign

I'll complete this tooling issue

@github-actions
Copy link

🚀 Issue assigned to you @mikeee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants