Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing workflow status branch #1348

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

WhitWaldo
Copy link
Contributor

Description

Added a missing branch to switch statement to support WorkflowRuntimeStatus.Suspended. Thanks to @cgillum for pointing out where the error was.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1215

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • [N/A] Created/updated tests
  • Extended the documentation

Surprising, there's no unit test package for the workflow project. This should be remedied, but isn't particularly necessary for this patch as it's quite a minor add.

@WhitWaldo WhitWaldo requested review from a team as code owners September 13, 2024 05:46
Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@cgillum cgillum merged commit 3d1fa01 into dapr:master Sep 13, 2024
10 checks passed
@WhitWaldo
Copy link
Contributor Author

/assign

@WhitWaldo WhitWaldo deleted the workflow-suspended-status-fix branch September 13, 2024 16:48
@WhitWaldo WhitWaldo self-assigned this Oct 18, 2024
@WhitWaldo WhitWaldo added this to the v1.15 milestone Oct 18, 2024
humandigital-michiel pushed a commit to humandigital-agency/dapr-dotnet-sdk that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow status displays as Unknown after being paused using
2 participants