Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Fix default GRPC port to 50001 #1125

Closed
olitomlinson opened this issue Jul 8, 2023 · 4 comments
Closed

[Workflow] Fix default GRPC port to 50001 #1125

olitomlinson opened this issue Jul 8, 2023 · 4 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@olitomlinson
Copy link

As it stands, the default GRPC port for Workflows is not set to 50001.

Which means the OOTB experience is not as slick as it could be, as the DAPR_GRPC_PORT env var needs to be set to 50001 manually.

If the default was 50001, then this would make the OOTB experience slicker.

This has already caused some confusion for early adopters, as discussed on Discord.

@olitomlinson olitomlinson added the kind/bug Something isn't working label Jul 8, 2023
@halspang
Copy link
Contributor

@olitomlinson - The default is 50001 in what case are you not seeing that be true?

https://github.com/dapr/dotnet-sdk/blob/master/src/Shared/DaprDefaults.cs#L85

@olitomlinson
Copy link
Author

@halspang

Chris G has confirmed this is a problem with Workflows SDK. It's also reported by other users over on Discord.

I get this :
image

I think the underlying Durable Task SDK is defaulting to 4001, which is not what the Dapr SDK defaults to (as you have quite rightly pointed out, its 50001.

So to mitigate this, If I add an env var to my App :

DAPR_GRPC_PORT : 50001

image

it now works :

image

I suspect it's this which is not being overriden :

address = "http://localhost:4001";

https://github.com/microsoft/durabletask-dotnet/blob/1ec339906993fcb0e87172e3b909349598b1c05b/src/Client/Grpc/GrpcDurableTaskClient.cs#L349

@RyanLettieri
Copy link
Contributor

/assign

@olitomlinson
Copy link
Author

I've validated that this is now fixed in the latest pre-release 1.12.0-rc02

Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants