Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT env. #1124

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

artursouza
Copy link
Member

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1110

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from a team as code owners July 8, 2023 00:03
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #1124 (bcca04c) into master (574dc0c) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   67.22%   67.16%   -0.06%     
==========================================
  Files         170      170              
  Lines        5687     5695       +8     
  Branches      605      607       +2     
==========================================
+ Hits         3823     3825       +2     
- Misses       1723     1727       +4     
- Partials      141      143       +2     
Flag Coverage Δ
net6 67.09% <25.00%> (-0.06%) ⬇️
net7 67.09% <25.00%> (-0.06%) ⬇️
netcoreapp3.1 67.12% <25.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Actors/Runtime/ActorRuntimeOptions.cs 77.27% <ø> (ø)
src/Dapr.Client/DaprClientBuilder.cs 100.00% <ø> (ø)
src/Shared/DaprDefaults.cs 61.53% <25.00%> (-16.24%) ⬇️

Copy link
Contributor

@halspang halspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes for the comments, overall it looks good.

src/Shared/DaprDefaults.cs Outdated Show resolved Hide resolved
src/Shared/DaprDefaults.cs Outdated Show resolved Hide resolved
@halspang
Copy link
Contributor

@artursouza - Can you fix your DCO?

@artursouza
Copy link
Member Author

@artursouza - Can you fix your DCO?

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DAPR_HTTP_ENDPOINT and/or DAPR_GRPC_ENDPOINT
2 participants