-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT env. #1124
Conversation
examples/Client/PublishSubscribe/PublishEventExample/PublishEventExample.csproj
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 67.22% 67.16% -0.06%
==========================================
Files 170 170
Lines 5687 5695 +8
Branches 605 607 +2
==========================================
+ Hits 3823 3825 +2
- Misses 1723 1727 +4
- Partials 141 143 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes for the comments, overall it looks good.
@artursouza - Can you fix your DCO? |
Signed-off-by: Artur Souza <[email protected]>
Fixed. |
) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Erik O'Leary <[email protected]>
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1110
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: