Inroduce OnActorMethodFailedAsync virtual method to simplify error logging #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Rudenko <[email protected]>
vlardn
changed the title
|
Could someone either approve or at least comment on this? Half year is already passed :( |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 67.16% 67.12% -0.04%
==========================================
Files 170 170
Lines 5695 5698 +3
Branches 607 607
==========================================
Hits 3825 3825
- Misses 1727 1730 +3
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
halspang
approved these changes
Aug 16, 2023
|
Thanks for the contribution, sorry for the long delay! |
onionhammer
pushed a commit
to onionhammer/dotnet-sdk
that referenced
this pull request
Aug 22, 2023
…#1014) Signed-off-by: Vlad Rudenko <[email protected]> Signed-off-by: Erik O'Leary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, to catch exceptions thrown by any actor method (and log them somewhere) you need to add the
try/catchblock to ALL actor methods. For timer and reminder actor callbacks, this is almost mandatory, otherwise, exceptions will never appear anywhere. But all thesetry/catchblocks bloat the actors' code and make it less readable.Given change introduces the
OnActorMethodFailedAsyncvirtual method which can be overridden by the user the same way as theOnPreActorMethodAsyncorOnPostActorMethodAsyncmethods and can be used (in most cases) to log exceptions thrown by any actor method as well as byOnPreActorMethodAsyncorOnPostActorMethodAsyncoverridden methods. Overriding of theOnActorMethodFailedAsyncmethod significantly simplifies actor error logging code for the user.