Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update performance benchmarks #3818

Open
wants to merge 8 commits into
base: v1.12
Choose a base branch
from
Open

Update performance benchmarks #3818

wants to merge 8 commits into from

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Oct 12, 2023

Closes #3468

@yaron2 yaron2 requested review from a team as code owners October 12, 2023 00:21
@msfussell msfussell self-requested a review October 16, 2023 21:25
@msfussell msfussell added this to the 1.12 milestone Oct 16, 2023
@@ -19,7 +19,7 @@ For applications using actors in Dapr there are two aspects to be considered. Fi
* Sidecar Injector (control plane)
* Sentry (optional, control plane)

## Performance summary for Dapr v1.0
## Performance summary for Dapr v1.12

The actors API in Dapr sidecar will identify which hosts are registered for a given actor type and route the request to the appropriate host for a given actor ID. The host runs an instance of the application and uses the Dapr SDK (.Net, Java, Python or PHP) to handle actors requests via HTTP.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The actors API in Dapr sidecar will identify which hosts are registered for a given actor type and route the request to the appropriate host for a given actor ID. The host runs an instance of the application and uses the Dapr SDK (.Net, Java, Python or PHP) to handle actors requests via HTTP.
The actors API in Dapr sidecar identifies which hosts are registered for a given actor type and routes the request to the appropriate host for a given actor ID. The host runs an instance of the application and uses the Dapr SDK (.Net, Java, Python, Go) to handle actors requests via HTTP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link to the Actor performance test that we can include, so that people can try this themselves?


### Kubernetes performance test setup

The test was conducted on a 3 node Kubernetes cluster, using commodity hardware running 4 cores and 8GB of RAM, without any network acceleration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link to the performance test that we can include, so that people can try this themselves?


<img src="/images/perf_invocation_p99.png" alt="Latency for 99th percentile">
This performance is on par or better than commonly used service meshes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's quantify this with a link to service meshes perf results, otherwise this is hearsay and we should not include this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In removing the graphs, there is not mTLS measurement comparison. What impact does mTLS have on the performance tests, it would be good to at least clarify this with a % increase. The majority of people will use mTLS and so this number is important.

<img src="/images/perf_invocation_p90.png" alt="Latency for 90th percentile">

<br>
The Dapr sidecar uses 0.45 vCPU and 38Mb per 1000 requests per second.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Dapr sidecar uses 0.45 vCPU and 38Mb per 1000 requests per second.
The Dapr sidecar uses 0.45 vCPU and 38Mb per 1000 requests per second.

| Sentry | 0.005 | 13.6 Mb
| Sidecar Injector | 0.002 | 14.6 Mb
| Placement | 0.001 | 20.9 Mb
| Operator | 0.003 | 18 Mb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place that we capture the Control Plane numbers and are these consistently the same for all the performance test? If so we should separate these out. If not, then should each perf test have different control plane numbers like this one?

type: docs
title: "Pub/sub performance"
linkTitle: "Pub/sub performance"
weight: 20000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
weight: 20000
weight: 30000

type: docs
title: "State performance"
linkTitle: "State performance"
weight: 20000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
weight: 20000
weight: 40000

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions
Copy link

Stale PR, paging all reviewers

@hhunter-ms
Copy link
Collaborator

@yaron2 friendly bump

Copy link

github-actions bot commented Nov 5, 2023

Stale PR, paging all reviewers

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 27, 2023
@github-actions github-actions bot closed this Jan 3, 2024
@yaron2 yaron2 reopened this Jan 3, 2024
@hhunter-ms hhunter-ms removed the stale label Jan 9, 2024
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 15, 2024
@github-actions github-actions bot closed this Jan 23, 2024
@github-actions github-actions bot added the stale label Jul 14, 2024
@hhunter-ms hhunter-ms added P0 and removed stale labels Jul 15, 2024
Copy link

Stale PR, paging all reviewers

Copy link

Stale PR, paging all reviewers

Copy link

github-actions bot commented Aug 4, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Aug 4, 2024
@hhunter-ms hhunter-ms removed the stale label Aug 6, 2024
Copy link

Stale PR, paging all reviewers

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Aug 19, 2024
@github-actions github-actions bot closed this Aug 27, 2024
@hhunter-ms hhunter-ms reopened this Aug 27, 2024
@hhunter-ms hhunter-ms removed the stale label Aug 27, 2024
Copy link

github-actions bot commented Sep 2, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Sep 2, 2024
@github-actions github-actions bot closed this Sep 9, 2024
@yaron2 yaron2 reopened this Dec 2, 2024
@hhunter-ms hhunter-ms removed the stale label Dec 2, 2024
@hhunter-ms
Copy link
Collaborator

lol @msfussell @yaron2 remember this PR? should this be closed and reopened for 1.15?

Copy link

github-actions bot commented Dec 8, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 8, 2024
@hhunter-ms hhunter-ms removed the stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Perf numbers for the v1.14 release.
3 participants