-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to IWpfShell #32
Comments
I worked around this by not using the
|
Hi Magnus, sorry for the delay, so much to do... I agree that if you want to provide your shell in a separate assembly, it's unfortunate to add a dependency to my library. FYI: The logic for the IWpfShel can be found here: https://github.com/dapplo/Dapplo.Microsoft.Extensions.Hosting/blob/master/src/Dapplo.Microsoft.Extensions.Hosting.Wpf/Internals/WpfThread.cs#L69 You also don't NEED an application, but it's possible to override it's behavior to do exactly that what you did. I'm sure I can extend the configuration to add something that will add a similar behavior, without the need for you to add dependencies, but I prefer to keep the configuration small & simple as it will get way to many border-cases. If you are happy with your current solution, let me know and we can close this issue. P.S. Best wishes, |
Hi Robin!
I've been playing around some more with the library and I wonder if it would be possible to find an alternative solution to the
IWpfShell
marker interface. Let's say that the shell is located in separate assembly from the host. It would be nice to avoid the dependency on the marker interface in that case.Perhaps the API could have a method
UsingWpfShell<TShell>()
instead and use the provided type for lookup.Or would you say this is out of scope and rather recommend using a custom implementation of
ConfigureWpf
alltogether?The text was updated successfully, but these errors were encountered: