-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unreachable if condition #9
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey folks,
I just noticed that, there is an if-else condition in the Edition init method, where it is checking that if
maxMintSize
is 0 or not, in case of 0, it is initializingself.maxMintSize
tonil
otherwiseself.maxMintSize
to givenmaxMintSize
, here is the code of that conditionBut in my views, code under if block, never execute or you can say it is unreachable code due to the pre block of the Edition init method, where we already checking that
maxMintSize
should not equal to 0Here you can check, there is already a condition to check if
maxMintSize
is 0 or not, in case of 0, it will be return from this block, as it is pre-block of the method.So we can remove if condition inside the init method as we already checked in pre-block and directly assign
self.maxMintSize
to givenmaxMintSize
. But if it is deployed than I don't think so you can update that code, but you can checkThanks
The text was updated successfully, but these errors were encountered: