-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop issue #8
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey folks,
I just read your AllDay contract for learning purpose, I noticed that, there is a
batchDeposit
method which is getting a collection of NFTs as input parameter and deposit that NFTs in user collection. You have added loop to deposit each NFT from the collection of NFTs.In my opinion there should be a limit on how many NFTs (max) will be deposit through above method, right now there is no any limit, so it will be cause an issue in case of long NFT collection, so there should be limit as pre-condition of method e.g:
Also you can add if tokens are shouldn't be nil or at least there must be 1 NFT in the collection as pre-condition
Thanks
The text was updated successfully, but these errors were encountered: