Never push to registry with linting workflow (#16)

dantp-ai · Aug 18, 2024 · 3e0807e · 3e0807e
1 parent 81ed6d6
commit 3e0807e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/lint-format-typecheck.yaml b/.github/workflows/lint-format-typecheck.yaml
@@ -42,11 +42,7 @@ jobs:
       uses: devcontainers/[email protected]
       with:
         imageName: ghcr.io/${{ secrets.GH_DOCKER_REGISTRY_NAMESPACE }}/${{ vars.CONTAINER_IMAGE_NAME }}
-        # Push new container image if `eventFilterForPush` and `refFilterForPush` (by default allow all branches to trigger a push of the container image) are true
-        push: filter
-        # Push new image only if event name that triggered this workflow matches `push`
-        # If a pull request triggered it, then skip pushing new container image to registry
-        eventFilterForPush: push
+        push: never
         runCmd: |
           poetry run ruff check --fix
           poetry run ruff format .

diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml
@@ -41,7 +41,10 @@ jobs:
       uses: devcontainers/[email protected]
       with:
         imageName: ghcr.io/${{ secrets.GH_DOCKER_REGISTRY_NAMESPACE }}/${{ vars.CONTAINER_IMAGE_NAME }}
+        # Push new container image if `eventFilterForPush` and `refFilterForPush` (by default allow all branches to trigger a push of the container image) are true
         push: filter
+        # Push new image only if event name that triggered this workflow matches `push`
+        # If a pull request triggered it, then skip pushing new container image to registry
         eventFilterForPush: push
         runCmd: |
           poetry run pytest