-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserving of P8SCII Control Codes #89
Comments
Just ran into this one again while updating SCUMM-8. |
I also needed to write instructions such as "Press 🅾 (O glyph)" and the 🅾 (O glyph) became "ユか✽ゆヤま◆". After processing Lua content with Python, it was even flattened to "_______" (this is an issue on my side, not sure why as I'm processing UTF-8; but first the issue must be fixed on picotool side, then I can see if I need more work to make the glyph work). I saw some update of glyphs and updated picotool to latest, but the issue was still there. |
I recently encountered the same issue as @hsandt and decided to look into it. I was able to remove the issue by disabling all unescaping of P8SCII escape sequences. I believe this should solve your issue as well, @Liquidream. I made a PR for the suggested fix. |
(I believe you've yet to look at P8SCII, so this is just an FYI for when you do)
Currently, when picotool/luamin processes source files wish such code as below:
...it results in the backslashes being escaped (breaking the P8SCII Control Codes):
The text was updated successfully, but these errors were encountered: