Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make firefox containers support switchable #399

Open
banditByte opened this issue Oct 29, 2024 · 9 comments
Open

Make firefox containers support switchable #399

banditByte opened this issue Oct 29, 2024 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@banditByte
Copy link

Thank you for your add-on, I use it constantly and with great pleasure.
Personally, I really like the ability to customize every aspect of the WebScrapBook. So I'd be extremely grateful if you could add the ability to disable the firefox containers support. I think this is well implemented in the All Tabs Helper add-on:
suppurt for firefox Containers feature settings in add-on preferences 2

Best regards

@danny0838
Copy link
Owner

What behavior do you expect by mentioning "disable Firefox container"?

@banditByte
Copy link
Author

banditByte commented Oct 29, 2024

What behavior do you expect by mentioning "disable Firefox container"?

Problem: After the release of the new version of the WebScrapBook, my Firefox began to use containers without any alternative. The firefox settings page states that the use of containers is necessary for the WebScrapBook to work.

I suggest making container support switchable so that it can be disabled in the WebScrapBook if not needed. So the browser did not use containers at all, and the WebScrapBook worked as before the latest update.
It would be ideal if the WebScrapBook could detect if Firefox container feature is activated in the browser and enable container support only in such cases

@danny0838
Copy link
Owner

danny0838 commented Oct 29, 2024

I get it. Unfortunately this is not possible—the related permission (contextualIdentities) cannot be made optional. (Also see the related Bug 1386673)

The feature for All Tabs Helper you have mentioned is a different thing, it happens to not require such permission to work.

@danny0838 danny0838 added the enhancement New feature or request label Oct 29, 2024
@banditByte
Copy link
Author

Thanks for the reply, although it's not encouraging. I'll have to stuck with the previous version of the WebScrapBook obviously.

@banditByte banditByte changed the title Add the ability to disable firefox containers support Make firefox containers support switchable Oct 29, 2024
@danny0838
Copy link
Owner

Revoked container requirement in 2.16.1, until a better permission design is implemented by Firefox or we have found a better solution.

@danny0838 danny0838 added the help wanted Extra attention is needed label Oct 30, 2024
@Saectar
Copy link

Saectar commented Nov 23, 2024

In my case I have a problem capturing tabs when I am browsing a container, I get the following error:

Capturing (document) [168] https://github.com/ ...
Fatal error: Disallowed to capture a tab in container "firefox-container-13" from container "firefox-default"

@danny0838
Copy link
Owner

As aforementioned, currently there is no way to support a non-default container without causing compatibility (and some other) issues. We decided to not support it until Firefox makes a change or we have come up with a good solution.

@roguestar
Copy link

In my case I have a problem capturing tabs when I am browsing a container, I get the following error:

Capturing (document) [168] https://github.com/ ...
Fatal error: Disallowed to capture a tab in container "firefox-container-13" from container "firefox-default"

I have the same problem. Would be nice to have the option as a separate build available for those that use containers since it sounds like it's a Firefox problem. I rolled back to the old build and have disabled WSB updates in the meantime, I'm just hoping I remember to check back when the root issue is resolved, but I won't hold my breathe waiting on Firefox. It's understandable why WSB devs wouldn't want the overhead of at minimum maintaining 2 builds and code differences for a Firefox issue though.

@danny0838
Copy link
Owner

Although it's a Firefox issue, it is understandable that the "requires container" extension permission cannot be set optional, which may make the container system over-complicated and likely error-prone. As a result, I don't think it will likely be changed in the future.

The root source is the container system itself, which is making the browser over-complicated.

If you really want to roll back to an earlier version, use 2.16.0 instead of earlier versions, which never checks for container and may cause inconsistency, or even worse—a security issue, when capturing a non-default container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants