-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make firefox containers support switchable #399
Comments
What behavior do you expect by mentioning "disable Firefox container"? |
Problem: After the release of the new version of the WebScrapBook, my Firefox began to use containers without any alternative. The firefox settings page states that the use of containers is necessary for the WebScrapBook to work. I suggest making container support switchable so that it can be disabled in the WebScrapBook if not needed. So the browser did not use containers at all, and the WebScrapBook worked as before the latest update. |
I get it. Unfortunately this is not possible—the related permission ( The feature for All Tabs Helper you have mentioned is a different thing, it happens to not require such permission to work. |
Thanks for the reply, although it's not encouraging. I'll have to stuck with the previous version of the WebScrapBook obviously. |
Revoked container requirement in 2.16.1, until a better permission design is implemented by Firefox or we have found a better solution. |
In my case I have a problem capturing tabs when I am browsing a container, I get the following error:
|
As aforementioned, currently there is no way to support a non-default container without causing compatibility (and some other) issues. We decided to not support it until Firefox makes a change or we have come up with a good solution. |
I have the same problem. Would be nice to have the option as a separate build available for those that use containers since it sounds like it's a Firefox problem. I rolled back to the old build and have disabled WSB updates in the meantime, I'm just hoping I remember to check back when the root issue is resolved, but I won't hold my breathe waiting on Firefox. It's understandable why WSB devs wouldn't want the overhead of at minimum maintaining 2 builds and code differences for a Firefox issue though. |
Although it's a Firefox issue, it is understandable that the "requires container" extension permission cannot be set optional, which may make the container system over-complicated and likely error-prone. As a result, I don't think it will likely be changed in the future. The root source is the container system itself, which is making the browser over-complicated. If you really want to roll back to an earlier version, use 2.16.0 instead of earlier versions, which never checks for container and may cause inconsistency, or even worse—a security issue, when capturing a non-default container. |
Thank you for your add-on, I use it constantly and with great pleasure.
Personally, I really like the ability to customize every aspect of the WebScrapBook. So I'd be extremely grateful if you could add the ability to disable the firefox containers support. I think this is well implemented in the All Tabs Helper add-on:
Best regards
The text was updated successfully, but these errors were encountered: