Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close a tab after a capture #392

Open
i3v opened this issue Aug 18, 2024 · 5 comments
Open

Auto-close a tab after a capture #392

i3v opened this issue Aug 18, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@i3v
Copy link

i3v commented Aug 18, 2024

It would be great to have an easily-available "Capture tabs and auto-close" main menu item just below the normal "Capture tabs".
Personally, I'd use both of them.

In this case, the "Options -> User interface -> Auto-close dialog on capture complete" could be re-purposed to control just the behavior of the new "Capture tabs and auto-close" menu button (personally, I'd like to use "If no warning, error, or failure").

@danny0838
Copy link
Owner

danny0838 commented Aug 18, 2024

We don't tend to do this as there would be lots of "capture tabs and auto close", "apture bookmark and auto close", etc. if we propagate that, let alone possibly different values for auto close.

I think that the auto close behavior is a rather universal personal preference and not likely changed. Is there a rationale that auto-close and non-auto-close be both frequently used?

@i3v
Copy link
Author

i3v commented Aug 18, 2024

Well, I do understand your concern...
My rationale for me is very simple:

  • Sometimes I'm still reading a page when I decide that I want to capture it. I definitely don't want it to get closed suddenly. Neither I want to keep in mind that I have to capture it later.
  • Sometimes I'm already done reading and then I decide to capture it. I don't really want to wait for the capturing process to finish, neither I want to thing about this page again in the next few minutes.

@danny0838
Copy link
Owner

danny0838 commented Aug 19, 2024

Well, this feature does not afftct the page tab at all. It closes only the capture dialog window.

@i3v
Copy link
Author

i3v commented Aug 19, 2024

Ha, I was a bit wrong about that option then.
For the scenario I mentioned, it would be nice, if the tab(s) would get auto-closed (if there would be no errors).

@danny0838
Copy link
Owner

It will be a feature request, then.

We generally don't tend to do this since closing a tab after a capture is beyond the core functionality. You can also do something like grouping the pages to be captured in another window and close them all together afterwards.

@danny0838 danny0838 added the enhancement New feature or request label Aug 19, 2024
@danny0838 danny0838 changed the title "Capture tabs and auto-close" alongside normal "Capture tabs" Auto-close a tab after a capture Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants