Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service annotations missing, so not possible to use prometheus autodiscovery #337

Open
gpkc opened this issue Nov 30, 2024 · 2 comments
Open

Comments

@gpkc
Copy link
Contributor

gpkc commented Nov 30, 2024

As far as I understand, it's not possible to set e.g. prometheus.io/port and prometheus.io/scrape on the Service annotations currently, and prometheus autodiscovery would look for those. It's possible to set on the pod, but this is not ideal since it could cause metrics to be duplicated momentarily if two copies coexist, and since the pod port is not directly configurable as well, and could change in the future

@danihodovic
Copy link
Owner

Would you like to open a pull-request?

@gpkc
Copy link
Contributor Author

gpkc commented Dec 1, 2024

@danihodovic Sure! #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants