Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable @primary-color is undefined #9

Open
Lamboy88 opened this issue Jan 3, 2020 · 3 comments
Open

variable @primary-color is undefined #9

Lamboy88 opened this issue Jan 3, 2020 · 3 comments

Comments

@Lamboy88
Copy link

Lamboy88 commented Jan 3, 2020

Hi Daniel,
thank you for the great extension. Unfortunately, it is not working in my installation. Seeing the error message it is obvious what is the problem, but I don´t know how to solve it. Any ideas welcome. Thank you

Command failed: grunt server-build:prod --outputdir=courses/.../.../build --theme=... --menu=adapt-contrib-boxMenu

Fatal error: {
"message": "variable @primary-color is undefined",
"type": "Name",
"filename": "src/extensions/adapt-backgroundScroll/less/backgroundScroll.less",
"index": 334,
"line": 25,
"column": 13,
"callLine": null,
"extract": [
".bgscroll-body {",
"\tbackground: @primary-color;",
"\tcolor: #ffffff;"
]
}

It is a fresh installation - Authoring Tool (0.10.2 . FrameWork 5.1.0) - Theme Vanilla

@gonzalomanb
Copy link

Can you was resolved?

@amygroshek
Copy link
Contributor

I'm seeing this also.

AT version: 0.10.3
Framework version: 0.5.4
Theme: vanilla

According to what I've been told here
this is happening because this plugin has not been updated for v0.5 of the framework. So at present your options are to downgrade the framework or find something else (or make the required changes in a PR).

Command failed: grunt server-build:prod --outputdir=courses/5ebc1dbb7268623938f00056/5ebd1f239d6ed208d7c6c966/build --theme=5ebc20e06ab31b39cd1c8661 --menu=adapt-contrib-boxMenu

Fatal error: {
 "message": "variable @primary-color is undefined",
 "type": "Name",
 "filename": "src/extensions/adapt-backgroundScroll/less/backgroundScroll.less",
 "index": 334,
 "line": 25,
 "column": 13,
 "callLine": null,
 "extract": [
  ".bgscroll-body {",
  "\tbackground: @primary-color;",
  "\tcolor: #ffffff;"
 ]
}�

@DmitriiKasnitskii
Copy link

DmitriiKasnitskii commented Jul 9, 2020

@Lamboy88

I've discovered some issues that you should resolve to build this scroll for the modern Framework (5+).

First issue - remove @primary-color and @button-color from backgroundScroll.less. Actually most of these styles are unused for now (Except .bgscroll-images, .bgscroll-background and .page.bgscroll).

Second issue - in the new Framework version some classes has been renamed and for solving this issue you should change the following thing in BackgroundScrollView.js

this.offsetTop = $('.navigation').height();
to
this.offsetTop = $('.nav__inner').height();

This slight changes allow you to "migrate" for framework Version 5+

Then use ForceRebuild on your project.

All previous issues and how to make it works were discovered here.

Unfortunately I don't have permissions to create branch and then merge request it to this repository, so I can only advice to fix it by yourself inside the code.

P.S. You can find this files in
\adapt_authoring\temp**{ID from URL}**\adapt_framework\src\extensions\adapt-backgroundScroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants