Fix scrollBehavior='none' on path update

Fixes remix-run#369. Test Plan: npm test
danieljuhl · Oct 8, 2014 · caf3a2b · caf3a2b
1 parent 93e7341
commit caf3a2b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/modules/mixins/ScrollContext.js b/modules/mixins/ScrollContext.js
@@ -76,10 +76,10 @@ var ScrollContext = {
 
   updateScroll: function (path, actionType) {
     var behavior = this.getScrollBehavior();
-    var position = this._scrollPositions[path];
 
-    if (behavior && position)
-      behavior.updateScrollPosition(position, actionType);
+    if (behavior != null && this._scrollPositions.hasOwnProperty(path)) {
+      behavior.updateScrollPosition(this._scrollPositions[path], actionType);
+    }
   },
 
   /**

diff --git a/modules/mixins/__tests__/ScrollContext-test.js b/modules/mixins/__tests__/ScrollContext-test.js
@@ -29,6 +29,12 @@ describe('ScrollContext', function () {
     it('has a null scroll behavior', function () {
       expect(component.getScrollBehavior()).toBe(null);
     });
+
+    it('does not throw when updating scroll position', function () {
+      expect(function() {
+        component.updateScroll('/');
+      }).toNotThrow();
+    });
   });
 
   describe('when using scrollBehavior="browser"', function () {