Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding not recognized by iconv-lite #8

Open
leruitga-ss opened this issue Nov 26, 2024 · 0 comments
Open

encoding not recognized by iconv-lite #8

leruitga-ss opened this issue Nov 26, 2024 · 0 comments

Comments

@leruitga-ss
Copy link

leruitga-ss commented Nov 26, 2024

Hello,

Some encodings (at least for x-mac-cyrillic) detected by Jschardet are not handled by iconv, leading to unhandled error when piping to stream.

One quick solution could be to be able to provide detectEncodings property to jschardet#detect function, to blacklist some unhandled encondings. It's already possible to provide minimumThreshold (as minConfidence), so it may be a good idea to also enable detectEncondings.

Let me know what you think, I can make a PR if needed!

Thanks!
Kind regards,
Gauthier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant