Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowCompleted event never get published by SingleNodeEventHub (simple example included) #836

Open
mamift opened this issue May 28, 2021 · 3 comments · May be fixed by #912
Open

WorkflowCompleted event never get published by SingleNodeEventHub (simple example included) #836

mamift opened this issue May 28, 2021 · 3 comments · May be fixed by #912

Comments

@mamift
Copy link

mamift commented May 28, 2021

Describe the bug
The WorkflowCompleted event never gets published when a workflow completes.

To Reproduce
See this GitHub repo: https://github.com/mamift/WorkflowCoreTests

Expected behavior
The WorkflowCompleted should get published by the SingleNodeEventHub when the workflow completes.

Additional context
I was playing around with this gist to asynchronously await workflow completion, but it never worked for me; hanging as if deadlocked, but now I realised it wasn't because of the aforementioned gist code, it's because WorkflowCompleted never got published. For instance at this [line],(https://github.com/mamift/WorkflowCoreTests/blob/e75cac0aa2b092725ee2ce5ae8eabac3f2051ef7/SimpleWfTest/Program.cs#L31), it simply never triggers.

I suspect too in my simple example (link above) I may be using the API wrong, but I based it off the HelloWorld example found here.

@mamift mamift changed the title Why does the WorkflowCompleted event never get published by SingleNodeEventHub (simple example included) WorkflowCompleted event never get published by SingleNodeEventHub (simple example included) May 28, 2021
@vladimir-kovalyuk
Copy link

vladimir-kovalyuk commented Sep 9, 2021

@danielgerlag I've created PR to fix this #912 please have a look.

My impression is that it would be better to re-factor DetermineNextExecutionTime and move notification out of it. I will experiment with this later. Now I think we need just a quick fix in production.

@vladimir-kovalyuk
Copy link

@danielgerlag it has been about 5 month since I've provided quick fix. Any feedback on it?

@andrei-micuda
Copy link

@danielgerlag any way this could be taken into consideration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants