Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent the keyboard follow the camera #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

horacioh
Copy link

solves #1

I don't know if moving the keyboard is a usecase some people want (i Don't) but if so, I think a better solution would be to setup the keyboard position as a parameter when initializing the keyboard.

what do you think?

solves #1 

I don't know if moving the keyboard is a usecase some people want (i Don't) but if so, I think a better solution would be to setup the keyboard position as a parameter when initializing the keyboard.

what do you think?
@danielbuechele
Copy link
Owner

Hey, thanks so much for the PR! The problem I see with your implementation is that the keyboard is always shown in the same position, no matter where I am currently looking. This might cause the keyboard to show up behind me.

A possible solution would be to set the surface's angle once, when the keyboard is shown, and then not update afterwards.

@horacioh
Copy link
Author

ok that sounds reasonable!.
in my testing with the oculus that did not happend, but I guess its better to go safe and calculate it just once.

let me change that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants