You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the latest danger-swift-with-swiftlint Docker image is using SwiftLint 0.48.0 which was released in July 2022, so it's a couple of versions behind. This introduces some issues:
In our team, we try to keep the SwiftLint dependency up-to-date and move to the recent version when it comes out. This leads to a mismatch between the SwiftLint version we use locally and the one used by Danger Swift, which can cause some issues to be reported locally but not on CI (or vice versa).
We're currently experiencing an issue with a SwiftLint false positive that has been fixed in one of the latest releases, but the Danger plugin is still using the old one. So we don't experience this false positive locally, but it fails our CI check.
As far as I understand, bumping the SwiftLint version would require a new Danger Swift release. Would this alone be a good enough reason for a new release? If so, are we encouraged to do it?
The text was updated successfully, but these errors were encountered:
I'd love to see this fixed too. Maybe some workaround to allow pointing to a custom swiftlint binary, so that we don't have to require a new Danger Swift release. Or some other way.
Currently the latest
danger-swift-with-swiftlint
Docker image is using SwiftLint 0.48.0 which was released in July 2022, so it's a couple of versions behind. This introduces some issues:As far as I understand, bumping the SwiftLint version would require a new Danger Swift release. Would this alone be a good enough reason for a new release? If so, are we encouraged to do it?
The text was updated successfully, but these errors were encountered: