You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A common ancestor with base is useful to compare against the starting point of a PR.
For example, consider checking a change to an API being backwards compatible. In my PR, I'm adding a field foo which is a backward compatible change. It's possible that someone else has merged a change to the base branch adding field bar. My PR is not removing field bar but if I compare the two files naively, it would appear as if my PR removes field bar.
In terms of git, it's essentially the result of git merge-base ${danger.git.head} ${danger.git.base}.
The text was updated successfully, but these errors were encountered:
This might be hard to do across all hosting platforms (as that usually lives in the API of github/gitlab etc) but you're welcome to try give it a shot on one or two if there's APIs you can find for it
IIUC,
danger.git.base
ismaster
on localA common ancestor with base is useful to compare against the starting point of a PR.
For example, consider checking a change to an API being backwards compatible. In my PR, I'm adding a field
foo
which is a backward compatible change. It's possible that someone else has merged a change to the base branch adding fieldbar
. My PR is not removing fieldbar
but if I compare the two files naively, it would appear as if my PR removes fieldbar
.In terms of git, it's essentially the result of
git merge-base ${danger.git.head} ${danger.git.base}
.The text was updated successfully, but these errors were encountered: