Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCV5: rename input to img in pcv.spectral_index.egi #1598

Open
HaleySchuhl opened this issue Sep 17, 2024 · 0 comments
Open

PCV5: rename input to img in pcv.spectral_index.egi #1598

HaleySchuhl opened this issue Sep 17, 2024 · 0 comments
Labels
new feature New feature ideas and solutions
Milestone
PlantCV v5.0

Comments

@HaleySchuhl
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In #1593 we updated EGI to allow for both RGB and HSI input, but renaming the parameter to the more general img would be a breaking change, so wait to update this until v5.0.

Additional context
Parameter naming consistency increases usability and we try to make parameter names informative to the type of input expected.
@HaleySchuhl HaleySchuhl added the new feature New feature ideas and solutions label Sep 17, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v5.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature ideas and solutions
Projects
None yet
Milestone
PlantCV v5.0
Development

No branches or pull requests
1 participant
@HaleySchuhl