Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize humans names to "Last, First" #255

Closed
yarikoptic opened this issue Oct 31, 2024 · 2 comments
Closed

Standardize humans names to "Last, First" #255

yarikoptic opened this issue Oct 31, 2024 · 2 comments

Comments

@yarikoptic
Copy link
Member

Similarly we likely to pursue it at the level of BIDS:

since without that, it is impossible to separate full name into First and Last for a more detailed schema, as e.g. in openMINDS (@lzehl).

ATM we have also just

    name: Optional[str] = Field(None, json_schema_extra={"nskey": "schema"})

and just a "convention" stated somewhere to possibly enter as "Last, First".

WDYT @satra -- should we aim to harmonize or at least going forward to more explicitly encourage Last, First form?

@satra
Copy link
Member

satra commented Oct 31, 2024

that's weird. i'm sure i've seen both examples or Last, First on the meditor (which is based on json). perhaps it was adjusted sometime because of keeping the variable description more consistent. we should check.

@yarikoptic
Copy link
Member Author

indeed, I was "mislead" we do indeed have

class Person(Contributor):
    ...
    name: str = Field(
        description="Use the format: familyname, given names ...",
        pattern=NAME_PATTERN,
        json_schema_extra={"nskey": "schema"},
        examples=["Lovelace, Augusta Ada", "Smith, John", "Chan, Kong-sang"],
    )

and I guess I was citing the

class Contributor(DandiBaseModel):
    ...
    name: Optional[str] = Field(None, json_schema_extra={"nskey": "schema"})

which is the base class for Person where we restrict name to follow the Last, First convention. And as Contributor could also be the Organization where indeed it doesn't make sense to enforce Last, First -- it is all "ok"

but also we have

class RelatedParticipant(DandiBaseModel):
    identifier: Optional[Identifier] = Field(
        None, json_schema_extra={"nskey": "schema"}
    )
    name: Optional[str] = Field(
        None,
        title="Name of the participant or subject",
        json_schema_extra={"nskey": "schema"},
    )

where hopefully we would not need Last, First and it could potentially be the animal name I guess..

But I think in general we are ok, sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants