Use a dedicated logger. not top level logging. module #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the other submodules already used a dedicated logger. I have just identifier where root logging. was still used and similarly established loggers based on the files __name__ which should include the path starting with dandiapi. happen someone needs tighter control over logging of the application
yarikoptic
changed the title
mvandenburgh
approved these changes
Nov 20, 2024
|
Thank you @mvandenburgh for the rapid review/approval -- let's proceed then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the other submodules already used a dedicated logger. I have just identifier where root logging. was still used and similarly established loggers based on the files name which should include the path starting with dandiapi. happen someone needs tighter control over logging of the application