Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use feature to enable unstable tests/benches on nightly Rust #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mykmelez
Copy link
Contributor

@mykmelez mykmelez commented Aug 6, 2018

@danburkert One strategy for running unstable tests/benches on nightly Rust—while still being able to run stable tests on stable Rust—is to create a feature that enables the unstable tests and then enable that feature only when compiling with nightly Rust.

This is discussed in https://internals.rust-lang.org/t/setting-cfg-nightly-on-nightly-by-default/1893/22, and https://github.com/hyperium/hyper uses it. This branch implements that strategy for lmdb-rs, which makes it possible to re-enable stable tests on stable Rust.

I suspect that converting to Criterion is a better long-term strategy. I recently converted https://github.com/mykmelez/kv-bench/ to Criterion, and it was reasonably straightforward (and unlocked additional capabilities). Nevertheless, this might be a worthwhile short-term fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant