use feature to enable unstable tests/benches on nightly Rust #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danburkert One strategy for running unstable tests/benches on nightly Rust—while still being able to run stable tests on stable Rust—is to create a feature that enables the unstable tests and then enable that feature only when compiling with nightly Rust.
This is discussed in https://internals.rust-lang.org/t/setting-cfg-nightly-on-nightly-by-default/1893/22, and https://github.com/hyperium/hyper uses it. This branch implements that strategy for lmdb-rs, which makes it possible to re-enable stable tests on stable Rust.
I suspect that converting to Criterion is a better long-term strategy. I recently converted https://github.com/mykmelez/kv-bench/ to Criterion, and it was reasonably straightforward (and unlocked additional capabilities). Nevertheless, this might be a worthwhile short-term fix.