Issues Digest

[github-actions]

Subscribe to this issue to receive a digest of all the issues in this repository.

[github-actions]

Digest Summary: 2023-06-05 14:21:27

... contains 13 changes across 3 issues, since 2023-06-02 14:21:27

Some info in JIRA #116

@damithc created this issue on 2023-06-04 17:30:23

You can use crontab guru to help generate your cron syntax and confirm what time it will run. To help you get started, there is also a list of [crontab guru examples](https://...

Issues Digest #115

@github-actions created this issue on 2023-06-04 17:21:48

Subscribe to this issue to receive a digest of all the issues in this repository.

@github-actions created this comment on 2023-06-05 07:25:56

Digest Summary: 2023-06-05 07:25:56

Tracked 6 changes across 3 issues

From 2023-06-02 07:25:55 to 2023-06-05 07:25:56

Some info in JIRA [#116](...

@github-actions created this comment on 2023-06-05 08:24:33

Digest Summary: 2023-06-05 08:24:32

Tracked 1 changes across 1 issues

From 2023-06-05 07:25:56 to 2023-06-05 08:24:32

Issues Digest [#115](http...

@github-actions created this comment on 2023-06-05 09:20:29

Digest Summary: 2023-06-05 09:20:28

Tracked 1 changes across 1 issues

From 2023-06-05 08:24:33 to 2023-06-05 09:20:28

Issues Digest [#115](http...

@github-actions created this comment on 2023-06-05 10:25:17

Digest Summary: 2023-06-05 10:25:16

Tracked 1 changes across 1 issues

From 2023-06-05 09:20:29 to 2023-06-05 10:25:16

Issues Digest [#115](http...

@github-actions created this comment on 2023-06-05 11:17:03

Digest Summary: 2023-06-05 11:17:02

Tracked 1 changes across 1 issues

From 2023-06-05 10:25:17 to 2023-06-05 11:17:02

Issues Digest [#115](http...

@github-actions created this comment on 2023-06-05 12:42:58

Digest Summary: 2023-06-05 12:42:58

Tracked 1 changes across 1 issues

From 2023-06-05 11:17:03 to 2023-06-05 12:42:58

Issues Digest [#115](http...

@github-actions created this comment on 2023-06-05 13:24:24

Digest Summary: 2023-06-05 13:24:23

Tracked 1 changes across 1 issues

From 2023-06-05 12:42:58 to 2023-06-05 13:24:23

Issues Digest [#115](http...

Can we also give automatic code quality suggestions #114

@damithc created this comment on 2023-06-04 17:31:37

Jira features:

• Powerful agile boards: Scrum and Kanban boards help agile teams break large, complex projects into manageable pieces of work so focused teams, working in sprints, ship faster.
• T...

@damithc created this comment on 2023-06-04 17:32:40

More on JIRA (attention @damithc ):

@damithc created this comment on 2023-06-05 04:11:33

• Powerful agile boards: Scrum and Kanban boards help agile teams break large, complex projects into manageable pieces of work so focused teams, working in sprints, ship faster.

Not sure about th...

@damithc created this comment on 2023-06-05 07:25:32

• Powerful agile boards: Scrum and Kanban boards help agile teams break large, complex projects into manageable pieces of work so focused teams, working in sprints, ship faster.

Not sure ab...

[github-actions]

Digest Summary: 2023-06-08 04:33:15

... contains 2 changes across 2 issues, since 2023-06-05 14:21:28

Some info in JIRA #116

@damithc created this comment on 2023-06-08 04:32:05

Adding a comment with a syntax error.

some 
code here

We should auto-close stray PRs #113

@damithc created this comment on 2023-06-08 04:32:41

Too much automation may not be a good thing though 🤔

[github-actions]

Digest Summary: 2023-06-18 06:11:48

... contains 2 changes across 2 issues, since 2023-06-08 04:33:15

Adding a patient should not include adding the appt together. #105

@damithc created this comment on 2023-06-18 06:10:43

Some parts of the user guide show adding of the appt, some parts don't.
I think it is better to keep these functions separate

I don't thinks this part is correct.

Some info in JIRA #116

@damithc created this comment on 2023-06-18 06:10:15

Adding a note here to see if the digest is triggered.

[github-actions]

Digest Summary: 2023-06-18 06:16:50

... contains 1 changes across 1 issues, since 2023-06-18 06:11:48

Some info in JIRA #116

@damithc modified this comment on 2023-06-18 06:13:46

Adding a note here to see if the digest is triggered.
Adding another sentence, to change the updated time.

[github-actions]

Digest Summary: 2023-06-18 15:29:15 (timezone: Singapore)

... contains 1 changes across 1 issues, since 2023-06-18 14:16:51

Error msg in add command #110

@damithc created this comment on 2023-06-18 15:28:38

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Seems legit.

[github-actions]

Digest Summary: 2023-06-18 22:20:17

... contains 1 changes across 1 issues, since 2023-06-18 15:29:16 (timezone: Singapore)

In the DG, in the use case, sometimes it starts with user, sometimes it starts with staff. #106

@damithc created this comment on 2023-06-18 21:23:53

I don't think this is an issue 🤔

[github-actions]

Digest Summary: 2023-06-19 02:23:36

... contains 2 changes across 2 issues, since 2023-06-18 22:20:18 (timezone: Singapore)

Failing backend component tests #11483

@NyndoND created this comment on 2023-06-19 01:30:41

I'm getting the same error, did you manage to resolve the issue?

Errors when I run the backend tests #12481

@NyndoND created and modified this issue on 2023-06-19 01:36:02

I followed the developer guide provided in the project documentation, but when I run the command to check the code line coverage of the tests, I get the following error:
I try to run: ./gradlew componentTests
and: ./gradlew componentTests jacocoReport

Guide link I followed: https://teammates.github.io/teammates/development.html

[github-actions]

Digest Summary: 2023-06-19 04:20:10

... contains 1 changes across 1 issues, since 2023-06-19 02:23:37 (timezone: Singapore)

Errors when I run the backend tests #12481

@guilherme-puida created this comment on 2023-06-19 03:46:08

This happens when running the componentTests under Powershell. The del command only exists in cmd, so it errors out when trying to delete temporary files created by the afterTestClosure in build.gradle.

A simple fix would be changing the afterTestClosure to be more shell-agnostic. I'll open a PR fixing this in a few moments :^)

[github-actions]

Digest Summary: 2023-06-19 22:22:33

... contains 2 changes across 2 issues, since 2023-06-19 04:20:10 (timezone: Singapore)

Make instructor getting started page more prominent #12268

@zhaojj2209 created this comment on 2023-06-19 21:28:36

@singhabhyudita Feel free to submit a PR for this issue.

Add a trigger for good first issues #12480

@athakaras created this comment on 2023-06-19 22:00:38

@weiquu sure! I haven't thought of what the comment will entail 100% but I was thinking something like the following:

Good First Issue - notes for new contributors

This issue is for new contributors only, so if you are new feel free to submit your pull request. Please note that we allow only one good first issue per contributor to give the opportunity to all contributors to practise.

To get started please read carefully our contributing guidelines

We do not assign issues. Please note that the team does not assign issues to individuals. If you want to take on an issue, simply state your interest in the comment section of the issue and a team member will answer shortly :)

If something is unclear or you need help, please post a message in our discussion forum

This is what I have thought so far to include in the comment. If you want me to add something or modify something else please let me know by all means!

[github-actions]

Digest Summary: 2023-06-19 23:21:42

... contains 1 changes across 1 issues, since 2023-06-19 22:22:33 (timezone: Singapore)

Add a trigger for good first issues #12480

@zhaojj2209 created this comment on 2023-06-19 22:23:01

Thanks for the suggestion, this was something I wanted to work on but didn't get around to doing. Feel free to submit a PR for this!

Have added a few things to the comment, other maintainers feel free to chip in as well.

**Good First Issue - Notes for Contributors**

This issue is for **first-time contributors only**. If you are new to TEAMMATES, feel free to submit a PR for this issue. 

*Please note that we allow only one `good first issue` per contributor.* If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the `help wanted` tag instead.

**We do not assign issues to contributors**. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

**To get started**, do read through our [contributing guidelines](https://teammates.github.io/teammates/contributing-doc.html) carefully, and [set up a development environment on your local machine](https://teammates.github.io/teammates/setting-up.html) before making a PR.

If you need any clarifications on our [developer guide](https://teammates.github.io/teammates/index.html), or are facing issues that are not found in our [troubleshooting guide](https://teammates.github.io/teammates/troubleshooting-guide.html), please [post a message in our discussion forum](https://github.com/TEAMMATES/teammates/discussions).

[github-actions]

Digest Summary: 2023-06-20 05:18:26

... contains 1 changes across 1 issues, since 2023-06-19 23:21:42 (timezone: Singapore)

Make instructor getting started page more prominent #12268

@singhabhyudita created this comment on 2023-06-20 04:29:28

@zhaojj2209 sure I'm on it!

[github-actions]

Digest Summary: 2023-06-21 09:46:23

... contains 1 changes across 1 issues, since 2023-06-20 05:18:27 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@matiasJoao created this comment on 2023-06-21 08:54:24

hi, this issue still open?

[github-actions]

Digest Summary: 2023-06-21 16:24:12

... contains 1 changes across 1 issues, since 2023-06-21 09:46:24 (timezone: Singapore)

Add a trigger for good first issues #12480

@athakaras created this comment on 2023-06-21 16:18:41

@zhaojj2209 i am raising a PR! Please let me know if it is okay:)

[github-actions]

Digest Summary: 2023-06-22 01:23:51

... contains 2 changes across 1 issues, since 2023-06-21 16:24:13 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@weiquu created this comment on 2023-06-22 00:33:33

Hi @matiasJoao, feel free to submit a PR for this issue

@matiasJoao created this comment on 2023-06-22 00:39:04

@weiquu Thank you, i will do it

[github-actions]

Digest Summary: 2023-06-22 16:24:02

... contains 1 changes across 1 issues, since 2023-06-22 01:23:52 (timezone: Singapore)

Instructor edit sessions page: Fix preview sessions button overflow #12275

@Zxun2 created this comment on 2023-06-22 16:18:32

Hello! May i ask if this issue has been taken? I'll like to work on this.

[github-actions]

Digest Summary: 2023-06-22 17:20:50

... contains 1 changes across 1 issues, since 2023-06-22 16:24:03 (timezone: Singapore)

Student home page: Make it easier to navigate courses #12287

@Zxun2 created this comment on 2023-06-22 16:29:44

Hello! May i check if this issue is available? I'll like to work on this.

[github-actions]

Digest Summary: 2023-06-22 20:39:36

... contains 1 changes across 1 issues, since 2023-06-22 17:20:51 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@matiasJoao created this comment on 2023-06-22 19:50:17

hi, i have a question,
in several components it imports a file called api-output, however this file that would be located in types does not exist.
does anyone know anything about it?

[github-actions]

Digest Summary: 2023-06-23 04:24:16

... contains 1 changes across 1 issues, since 2023-06-22 20:39:37 (timezone: Singapore)

Make instructor getting started page more prominent #12268

@singhabhyudita created this comment on 2023-06-23 04:09:51

Hi @zhaojj2209 , is this fine?

Also I already have a PR #12477 open (for issue #12269 ,which is ready for review). So shall I wait for that to be merged before opening a PR for this issue?

[github-actions]

Digest Summary: 2023-06-23 11:04:35

... contains 1 changes across 1 issues, since 2023-06-23 04:24:16 (timezone: Singapore)

Add Sort Functions to Admin Sessions Page #12467

@singhabhyudita created this comment on 2023-06-23 10:56:26

Hey @weiquu can I take up this one?

[github-actions]

Digest Summary: 2023-06-23 17:22:45

... contains 1 changes across 1 issues, since 2023-06-23 11:04:35 (timezone: Singapore)

Instructor editing questions: warning about visibility is removed if the edit is cancelled. #12400

@Zxun2 created this comment on 2023-06-23 17:17:25

Hello! May i check if there is anyone working on this currently? I would like to work on it.

[github-actions]

Digest Summary: 2023-06-23 18:28:37

... contains 1 changes across 1 issues, since 2023-06-23 17:22:45 (timezone: Singapore)

Set character limit on question description #12460

@Kingsterdam created this comment on 2023-06-23 18:11:19

Is this issue Available, I want to work on it ?

[github-actions]

Digest Summary: 2023-06-24 12:27:43

... contains 1 changes across 1 issues, since 2023-06-23 18:28:38 (timezone: Singapore)

Failing backend component tests #11483

@NicolasCwy created and modified this comment on 2023-06-24 11:44:22

@NyndoND Hi there just ran it on my computer and I am also getting 5 failing tests. The path for the generated reports has changed slightly since to build/reports/tests/componentTests/component-tests/component-tests.html

• testGetMidnightAdjustedInstantBasedOnZone
• testGenerateFeedbackSessionEmails_testUsersWithDeadlineExtensions
• testGenerateFeedbackSessionEmails_testSanitization
• testGenerateFeedbackSessionEmails
• testFormatDateTimeForDisplay

From what I recall and what I've seen in this report, its all capitalisation errors for time and might be because of my computers formatting, Mac M1. As long as you make a PR and the component tests passes in the CI, you should be good to go

[github-actions]

Digest Summary: 2023-06-25 10:18:13

... contains 5 changes across 5 issues, since 2023-06-24 12:27:43 (timezone: Singapore)

Instructor edit sessions page: Fix preview sessions button overflow #12275

@weiquu created this comment on 2023-06-25 08:21:14

Hi @Zxun2, feel free to submit a PR for this issue

Student home page: Make it easier to navigate courses #12287

@weiquu created this comment on 2023-06-25 08:21:07

Hi @Zxun2, feel free to submit a PR for this issue

Instructor editing questions: warning about visibility is removed if the edit is cancelled. #12400

@weiquu created this comment on 2023-06-25 08:20:56

Hi @Zxun2, feel free to submit a PR for this issue

Set character limit on question description #12460

@weiquu created this comment on 2023-06-25 08:22:51

Hi @Kingsterdam, feel free to submit a PR for this issue

Add Sort Functions to Admin Sessions Page #12467

@weiquu created this comment on 2023-06-25 08:22:07

@singhabhyudita, sure please go ahead

[github-actions]

Digest Summary: 2023-06-25 14:30:02

... contains 1 changes across 1 issues, since 2023-06-25 10:18:14 (timezone: Singapore)

Student home page: Make it easier to navigate courses #12287

@damithc modified this comment on 2023-06-25 14:09:56

My take:

I don't think clutter is not a major issue for typical users, for the following reasons:

• TEAMMATES is not adopted institute-wide. Hence it is unlikely there are students with many courses. I would be surprised if any regular student user had more than 5.
• Not many students link their TEAMMATES account to a Google account, as it is optional.
• With a sensible sort order (e.g., latest on top) and a good collapse logic (e.g., collapse all except first 3), the user doesn't need to bother about courses lower down in the page, same as we are not bothered by millions of results a Google search gives us.

Option 1 requires additional data to be stored, which is a permanent cost. However, we can certainly implement some auto-collapse logic for the home page so that older courses are collapsed automatically.

I'm OK with option 2 for a different reason: Students sometimes link their TEAMMATES accidentally to a Google account and want to unlink, resulting in support requests. It's nice if they can unlink the account themselves. That said, I'm not sure how this fits in with the new authentication model. Perhaps we can wait till that is rolled out first?

[github-actions]

Digest Summary: 2023-06-25 23:22:37

... contains 2 changes across 1 issues, since 2023-06-25 14:30:03 (timezone: Singapore)

Allow instructors to use start/end dates up to 12 months in future #12494

@damithc created this issue on 2023-06-25 23:04:05

Current: Instructors cannot choose start/end dates further than 3 months into the future

Suggested: Increase this limit to either 9 or 12 months

Reason: Some instructors set up their courses in advance (e.g., some will set up their fall courses during summer)

Requested by a user.

@damithc created this comment on 2023-06-25 23:06:24

@wkurniawan07 any cost (or other) downsides if we allow 9 or 12 months for start/end dates?

[github-actions]

Digest Summary: 2023-06-26 00:29:37

... contains 2 changes across 1 issues, since 2023-06-25 23:22:38 (timezone: Singapore)

Allow instructors to use start/end dates up to 12 months in future #12494

@wkurniawan07 created this comment on 2023-06-26 00:00:22

Not really. In essence the only reason for the limit is abuse prevention, so as long as the limit is sensible it can always be changed.

@damithc created this comment on 2023-06-26 00:25:06

Not really. In essence the only reason for the limit is abuse prevention, so as long as the limit is sensible it can always be changed.

Thanks for the confirmation @wkurniawan07

Let's set it to 12 months then, as 9 feels a bit random.

[github-actions]

Digest Summary: 2023-06-26 14:30:54

... contains 2 changes across 2 issues, since 2023-06-26 00:29:37 (timezone: Singapore)

Refactoring of sortable tables #12329

@Zxun2 created this comment on 2023-06-26 13:53:16

Hello! I will like to try refactoring the sessions table component. Is that okay?

Allow instructors to use start/end dates up to 12 months in future #12494

@Zxun2 created this comment on 2023-06-26 13:48:30

Hello! May I work on this issue?

[github-actions]

Digest Summary: 2023-06-26 23:23:18

... contains 1 changes across 1 issues, since 2023-06-26 14:30:54 (timezone: Singapore)

Refactoring of sortable tables #12329

@domlimm created this comment on 2023-06-26 23:21:10

@Zxun2 Hello! Feel free to submit a PR 👍🏻

[github-actions]

Digest Summary: 2023-06-27 01:23:48

... contains 1 changes across 1 issues, since 2023-06-26 23:23:19 (timezone: Singapore)

Make instructor getting started page more prominent #12268

@singhabhyudita created this comment on 2023-06-27 00:47:03

Pinging @domlimm @zhaojj2209 @weiquu @samuelfangjw

[github-actions]

Digest Summary: 2023-07-07 00:32:18

... contains 4 changes across 4 issues, since 2023-07-06 18:29:39 (timezone: Singapore)

Create Unit Tests for Feedback*QuestionDetails classes #1501

@domlimm created this comment on 2023-07-07 00:12:11

@sawilkhan You can try to run the related test files with code coverage to see if there is any missing test coverage in the respective class. You can do this via an IDE e.g., IntelliJ, by right clicking on a test file and Running with Coverage.

Move app ID and app version configuration out of build.properties #11569

@domlimm created this comment on 2023-07-06 23:36:10

@Divyansh9979 Hello, feel free to submit a PR for this issue. We do not assign issues to contributors.

Set character limit on question description #12460

@domlimm created this comment on 2023-07-06 23:37:39

Since @Kingsterdam has not replied, @khushboo-9876 are you still interested in taking this issue?

Do let us know, if not, we will have @sawilkhan take it.

Thanks!

Allow instructors to use start/end dates up to 12 months in future #12494

@domlimm created this comment on 2023-07-06 23:39:09

@sawilkhan Thank you for your interest! Unfortunately, it is being worked on by someone else. Please look for another issue 👍🏻

[github-actions]

Digest Summary: 2023-07-07 01:25:09

... contains 1 changes across 1 issues, since 2023-07-07 00:32:19 (timezone: Singapore)

Create Unit Tests for Feedback*QuestionDetails classes #1501

@sawilkhan created this comment on 2023-07-07 01:09:05

@sawilkhan You can try to run the related test files with code coverage to see if there is any missing test coverage in the respective class. You can do this via an IDE e.g., IntelliJ, by right clicking on a test file and Running with Coverage.

Sure im on it then. Thanks

[github-actions]

Digest Summary: 2023-07-07 02:26:44

... contains 1 changes across 1 issues, since 2023-07-07 01:25:10 (timezone: Singapore)

Instructor home page loads forever if attempt to copy a feedback sessions fail #12507

@Zxun2 created and modified this issue on 2023-07-07 01:39:41

• Environment: master

Steps to reproduce

• Go to Instructor Home Page
• Add a new course, New Course
• Copy any existing session from Sample Course 101 over to New Course

• Under New Course, copy the session again into the Sample Course 101

• Error toast pops up, and page loads forever.

• Clicking on the Home button on the navbar yields no results. Will only resolve by either hard refreshing or navigating to another page, and back

Expected behaviour

Returns back to the home page.

Actual behaviour

Page loads forever.

Additional info

NIL

[github-actions]

Digest Summary: 2023-07-07 14:29:39

... contains 1 changes across 1 issues, since 2023-07-07 02:26:44 (timezone: Singapore)

Give respondents a way to reset a rubric question submission #12508

@damithc created this issue on 2023-07-07 14:06:40

Current: After submitting a response to a rubric question, the respondent can edit the submission but there is no way to reset it i.e., set it to 'empty' state

Suggestion: Provide a Reset option for respondents, together with a confirmation dialog, to set the the question to empty state.

[github-actions]

Digest Summary: 2023-07-10 14:29:44

... contains 5 changes across 1 issues, since 2023-07-07 14:29:39 (timezone: Singapore)

Give respondents a way to reset a rubric question submission #12508

@Himasnhu-AT created this comment on 2023-07-10 13:54:45

Hi, i would like to work on this issue. I'm new to open-source and this platform. so may take some time to get started

@Zxun2 created this comment on 2023-07-10 14:02:07

Hi prof! I would like to work on this, I would like to clarify the following:

• Is the empty state you're referring to is as shown in the image below? Currently, you could achieve the following simply by re-selecting the answer you have chosen, and the state will toggle. But, you'll have to do so row by row.
  

• Does "resetting" implies deleting the response to this particular question in the BE? Or is it purely a FE change, where you simply provide a button to reset all rows (to empty state).

• Are we implementing this only for the "RUBRIC" question type?

@Himasnhu-AT created this comment on 2023-07-10 14:17:37

Hi @Zxun2, if you are asking me

Does "resetting" implies deleting the response to this particular question in the BE? Or is it purely a FE change, where you simply provide a button to reset all rows (to empty state).

button to reset all rows to empty state

Are we implementing this only for the "RUBRIC" question type?

I'm new to teammates open-source, so not sure about RUBRIC type. but i guess, i'll apply to all the question-types available

@damithc created this comment on 2023-07-10 14:23:38

@Zxun2

• Does "resetting" implies deleting the response to this particular question in the BE? Or is it purely a FE change, where you simply provide a button to reset all rows (to empty state).

Front end only. But after resetting, a saving the form/question should reset in the back end too.

• Are we implementing this only for the "RUBRIC" question type?

We can do it one question type at a time. Most types already have a way to do that (either in one-step or in manually changing the answer to empty values) but for Rubric questions it is impossible to go back to empty state after saving an answer.

@Himasnhu-AT created this comment on 2023-07-10 14:27:05

Okk

[github-actions]

Digest Summary: 2023-07-10 15:21:25

... contains 1 changes across 1 issues, since 2023-07-10 14:29:44 (timezone: Singapore)

Give respondents a way to reset a rubric question submission #12508

@Zxun2 created this comment on 2023-07-10 14:47:03

@damithc I see, thanks for the clarification! 🫡

[github-actions]

Digest Summary: 2023-07-12 11:30:53

... contains 1 changes across 1 issues, since 2023-07-10 15:21:26 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@AnkitaPatil2002 created this comment on 2023-07-12 11:22:06

if this issue is still open can i create a PR ?

[github-actions]

Digest Summary: 2023-07-12 15:20:59

... contains 1 changes across 1 issues, since 2023-07-12 11:30:53 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@weiquu created this comment on 2023-07-12 14:56:01

Hi @AnkitaPatil2002, sure feel free to submit a PR for this issue

[github-actions]

Digest Summary: 2023-07-12 18:27:58

... contains 2 changes across 2 issues, since 2023-07-12 15:20:59 (timezone: Singapore)

Improve UI of Error Toasts #11947

@domoberzin created this comment on 2023-07-12 17:57:06

Was attempting to fix this, following the conversation in this PR, but realised that by changing the whitespace property to pre-wrap or pre-line:

1. Some E2E tests fail due to new \n characters in the actual status message, compared to the expected
2. Visual appearance of longer messages in the toast are also formatted weirdly as seen in the image below

With all this in mind, I want to ask if there is perhaps a different way to display the error messages? One way I could think of would be to display the errors with different separators, for e.g.
Simply displaying it as a comma separated list without the array brackets or Error 1 || Error 2 || Error 3

Refactoring of sortable tables #12329

@weiquu modified this issue on 2023-07-12 18:15:39

Sortable tables are used in several pages, but a fair number of them don't make use of the sortable-table component. Searching sortable amongst .html files should bring up these 10 (unlikely to be more, but best to do a more thorough search):

• Extension confirm modal
• Per question view responses
• Sessions recycle bin table
• Sessions table (in progress)
• Student list
• Notifications table
• Copy instructors from other courses modal
• Instructor courses page
• Copy questions from other sessions modal
• Instructor session individual extension page

It would be good to refactor the above components to make use of the sortable-table component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced.

[github-actions]

Digest Summary: 2023-07-12 19:18:57

... contains 2 changes across 2 issues, since 2023-07-12 18:27:59 (timezone: Singapore)

Improve UI of Error Toasts #11947

@weiquu created this comment on 2023-07-12 19:17:52

Hi @domoberzin, the issue with the toast message above seems to be caused by lines 804-805 in instructor-course-edit-page.component.ts. I combined them into a single line and the toast message looked fine for me.

Could you also try setting the whitespace property to break-spaces and see if the E2E tests still fail? If so, then I think we can just go with your suggestion.

Instructor view session results (course-wide): Add separate button to download results by question #12283

@NyndoND created this comment on 2023-07-12 18:54:47

I created a pull request, if something is wrong, please let me know, thanks in advance for your attention TEAMMATES/teammates#12505

[github-actions]

Digest Summary: 2023-07-13 02:27:53

... contains 1 changes across 1 issues, since 2023-07-12 19:18:58 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@Venkateeshh created this comment on 2023-07-13 02:04:49

Anyone working on this issue ??

[github-actions]

Digest Summary: 2023-07-13 10:05:11

... contains 1 changes across 1 issues, since 2023-07-13 02:27:54 (timezone: Singapore)

Instructor home page: Improve display of card header on mobile #12279

@weiquu created this comment on 2023-07-13 09:12:42

Anyone working on this issue ??

Hi, @AnkitaPatil2002 has already expressed interest, so do find another issue to work on

[github-actions]

Digest Summary: 2023-07-13 15:20:37

... contains 1 changes across 1 issues, since 2023-07-13 10:05:12 (timezone: Singapore)

Improve UI of Error Toasts #11947

@domoberzin created this comment on 2023-07-13 14:33:14

Hello @weiquu, I've worked on it and seem to have found a way to fix the E2E errors by closing the toast after the message within it has been verified, and also by editing the messages to be formatted correctly. They can be found in this PR #12509.

Also, I want to mention that while working on this issue, I found that some E2E test errors, particularly those relating to toast, for example in this test run, were not very specific, since it says that the toast component cannot be found, but the actual error was that the status message did not match with the expected message. Should I open an issue for this?

[github-actions]

Digest Summary: 2023-07-13 20:47:37

... contains 2 changes across 2 issues, since 2023-07-13 15:20:38 (timezone: Singapore)

Improve UI of Error Toasts #11947

@weiquu created this comment on 2023-07-13 20:23:49

Thanks @domoberzin! Sure, feel free to open an issue for it

Nonspecific error messages on E2E tests #12513

@domoberzin created this issue on 2023-07-13 20:40:56

• Environment: master

Steps to reproduce
Modify any parameter of any verifyStatusMessage method call such that the expected message will differ from the actual status message in the toast in a specific E2E test.

Before modification:

After modification:

Expected behaviour
Test fails with an error relating to the failed assertion between expected and actual message.

Actual behaviour
Test freezes and fails with some permutation of this error: org.gradle.internal.serialize.PlaceholderException: Expected condition failed: waiting for presence of element located by: By.className: toast-body (tried for 25 second(s) with 500 milliseconds interval)

Example error in this test run

Additional info

[github-actions]

Digest Summary: 2023-07-13 23:22:16

... contains 1 changes across 1 issues, since 2023-07-13 20:47:37 (timezone: Singapore)

Refactoring of sortable tables #12329

@jasonqiu212 modified this issue on 2023-07-13 22:48:09

Sortable tables are used in several pages, but a fair number of them don't make use of the sortable-table component. Searching sortable amongst .html files should bring up these 10 (unlikely to be more, but best to do a more thorough search):

• Extension confirm modal
• Per question view responses
• Sessions recycle bin table
• Sessions table (In progress: #12501)
• Student list
• Notifications table
• Copy instructors from other courses modal
• Instructor courses page
• Copy questions from other sessions modal
• Instructor session individual extension page

It would be good to refactor the above components to make use of the sortable-table component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced.

[github-actions]

Digest Summary: 2023-07-14 03:16:41

... contains 1 changes across 1 issues, since 2023-07-13 23:22:17 (timezone: Singapore)

Release V8.28.0 #12514

@samuelfangjw created this issue on 2023-07-14 03:11:48

Scheduled for Friday, Jul 14, 2023, 10.30pm SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

[github-actions]

Digest Summary: 2023-07-14 20:45:16

... contains 2 changes across 1 issues, since 2023-07-14 03:16:41 (timezone: Singapore)

Release V8.28.0 #12514

@samuelfangjw modified this issue on 2023-07-14 20:22:46

Scheduled for Friday, Jul 14, 2023, 10.30pm SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

@samuelfangjw created this comment on 2023-07-14 20:24:42

V8.28.0 has been released by @samuelfangjw at July 14th, 2023, 08.19pm SGT.

Code contributions from: @LarsGielen, @NicolasCwy, @Sho-Shoo, @YvetteJian, @Zxun2, @anuth212, @aorlandou, @athakaras, @b-walton, @damoba, @domoberzin, @ellaella12, @guilherme-puida, @hollymvargas, @itsAfnanAlam, @justincavalli, @landa44, @leonardomilv3, @rai31218, @rhyses-pieces, @riotgage, @ryalin, @singhabhyudita, @techMedMau, @yash29896, @yujioshiro, @zhaojj2209
Review contributions from: @EuniceSim142, @cedricongjh, @domlimm, @jasonqiu212, @weiquu, @zhaojj2209

Ready for post-release check and deployment by PM (@damithc).

[github-actions]

Digest Summary: 2023-07-14 21:28:21

... contains 4 changes across 2 issues, since 2023-07-14 20:45:17 (timezone: Singapore)

Release V8.28.0 #12514

@damithc modified this issue on 2023-07-14 21:15:35

Scheduled for Friday, Jul 14, 2023, 10.30pm SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

@damithc created this comment on 2023-07-14 21:15:22

Thanks everyone who contributed 💯
Deployed but reverted to previous version as there is a minor bug #12517 that needs to be fixed first.

Instructors creating sessions: response visible time should be 'not now' by default #12517

@damithc created this issue on 2023-07-14 21:11:57

When an instructors is creating a new session,

Current:

The default Make response visible time is empty.

Expected:

Should be set to Not now.

Otherwise, there will be an error message upon saving.

Seems like a regression caused by V8.28

@damithc created this comment on 2023-07-14 21:13:59

Possibly caused by #12498
@Zxun2 can have a look?

[github-actions]

Digest Summary: 2023-07-14 23:23:18

... contains 2 changes across 1 issues, since 2023-07-14 21:28:21 (timezone: Singapore)

Instructors creating sessions: response visible time should be 'not now' by default #12517

@Zxun2 created and modified this comment on 2023-07-14 23:07:48

Apologies, I have submitted a PR for this!

@damithc created this comment on 2023-07-14 23:22:44

Apologies, I have submitted a PR for this!

No worries @Zxun2 . It's a rite of passage 😀
Thanks for the quick response.

[github-actions]

Digest Summary: 2023-07-15 02:27:13

... contains 1 changes across 1 issues, since 2023-07-14 23:23:18 (timezone: Singapore)

V8.28.1 #12520

@samuelfangjw created and modified this issue on 2023-07-15 01:56:57

Scheduled for Saturday, Jul 15, 2023, 10.00pm 10.00am SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

[github-actions]

Digest Summary: 2023-07-15 10:04:29

... contains 2 changes across 1 issues, since 2023-07-15 02:27:14 (timezone: Singapore)

V8.28.1 #12520

@samuelfangjw modified this issue on 2023-07-15 09:03:39

Scheduled for Saturday, Jul 15, 2023, 10.00pm 10.00am SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

@samuelfangjw created this comment on 2023-07-15 09:04:40

V8.28.1 has been released by @samuelfangjw at July 15th, 2023, 09.01am SGT.

Code contributions from: @Zxun2
Review contributions from: @domlimm, @weiquu

Ready for post-release check and deployment by PM (@damithc).

[github-actions]

Digest Summary: 2023-07-15 12:26:11

... contains 2 changes across 1 issues, since 2023-07-15 10:04:30 (timezone: Singapore)

V8.28.1 #12520

@damithc modified this issue on 2023-07-15 11:39:02

Scheduled for Saturday, Jul 15, 2023, 10.00pm 10.00am SGT.

Release Lead:

• Tagged the latest stable release code with the latest version number
• Released changelogs

PM:

• Deployed the new version
• Released the new version for end users

@damithc created this comment on 2023-07-15 11:39:21

Deployed and released. Thanks again for the quick patch release. 💯

[github-actions]

Digest Summary: 2023-07-16 14:27:24

... contains 1 changes across 1 issues, since 2023-07-15 12:26:12 (timezone: Singapore)

Instructor courses page: some items don't show spinners #10508

@rexong created this comment on 2023-07-16 14:22:38

Hi, can I start a PR for this?

[github-actions]

Digest Summary: 2023-07-16 15:19:34

... contains 1 changes across 1 issues, since 2023-07-16 14:27:24 (timezone: Singapore)

Instructor courses page: some items don't show spinners #10508

@domlimm created this comment on 2023-07-16 14:36:27

@rexong Sure, feel free to submit a PR!

[github-actions]

Digest Summary: 2023-07-16 17:20:04

... contains 1 changes across 1 issues, since 2023-07-16 15:19:34 (timezone: Singapore)

Nonspecific error messages on E2E tests #12513

@wkurniawan07 created this comment on 2023-07-16 16:37:57

This is not as simple as it sounds.

The nature of the verification is different: this is waiting for some event to happen, in this case for a toast with specified message to appear. Consider this scenario:

• Toast with the modified message appears in page
• Verification fails; wait for the specified timeout
• Another toast with totally unrelated message appears in page
• Verification fails

The suggested expected behaviour will compare the unrelated message, which is hardly any better. Granted that the chance of toast with unrelated message appearing is low, but it should show why it is not as simple as "show expected vs actual message".

[github-actions]

Digest Summary: 2023-07-16 19:17:40

... contains 2 changes across 1 issues, since 2023-07-16 17:20:04 (timezone: Singapore)

Instructor sending submission reminders: missing space between checkbox and label #12313

@Venkateeshh created this comment on 2023-07-16 18:46:02

Is anyone working on this issue still??

@weiquu created this comment on 2023-07-16 19:07:04

Nope, @Venkateeshh feel free to submit a PR for this issue

[github-actions]

Digest Summary: 2023-07-18 20:42:15

... contains 2 changes across 1 issues, since 2023-07-16 19:17:41 (timezone: Singapore)

Flickering questions when loading sessions results #12499

@tushargupta123 created this comment on 2023-07-18 19:42:09

Hey can i correct the issue ?

@domlimm created this comment on 2023-07-18 19:43:33

@tushargupta123 Hello, feel free to submit a PR for this.

[github-actions]

Digest Summary: 2023-07-20 09:42:04

... contains 1 changes across 1 issues, since 2023-07-18 20:42:16 (timezone: Singapore)

Refactoring of sortable tables #12329

@singhabhyudita created this comment on 2023-07-20 09:36:25

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

[github-actions]

Digest Summary: 2023-07-23 00:24:47

... contains 1 changes across 1 issues, since 2023-07-20 09:42:05 (timezone: Singapore)

Save all comments when saving responses for all questions #12527

@zhaojj2209 created this issue on 2023-07-22 23:34:02

Currently, the "Submit Responses to All Questions" button does not save comments. Given that comments for responses are now allowed for all question types (see #12426), it is all the more important that comments are saved along with the responses.

[github-actions]

Digest Summary: 2023-07-24 05:17:54

... contains 1 changes across 1 issues, since 2023-07-23 00:24:48 (timezone: Singapore)

Save all comments when saving responses for all questions #12527

@Saimurugeshwari created this comment on 2023-07-24 04:43:36

can I work on this issue.