Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dark mode color setting breaks completely - I believe this is due to Obsidian removing Translucency in the latest beta. #158

Closed
DudeThatsErin opened this issue Mar 7, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working / doesn't look right

Comments

@DudeThatsErin
Copy link

Describe the bug
When I enabled the theme and have custom selected, I can't use the theme anymore. I have closed and reopened Obsidian but the theme is unusuable.

To Reproduce

  1. Enable theme
  2. Enable Style Settings
  3. Change Theme Option for the color (I think) to Custom

Expected behavior
A custom theme be applied and allow me to change it.

Screenshots
image
image

Setup Information

  • Device Type: Desktop
  • Operating System: Windows 11 Home
  • Prism version: Latest version, I checked for updates before applying this theme. I can't see anything in Obsidian right now.
  • Color Schemes Used: Custom
  • Obsidian Version: 1.5.10
  • Obsidian Installer Version: 1.5.8
  • Related Community plugins:
    Plugins installed: 23
    Plugins enabled: 17
    1: Banners v2.0.5-beta
    2: BRAT v0.8.4
    3: Checklist v2.2.13
    4: DataLoom v8.15.12
    5: Calendar v1.5.10
    6: Dataview v0.5.64
    7: Discord Rich Presence v1.5.1
    8: Just Share Please v0.1.5
    9: Kanban v1.5.3
    10: Omnivore v1.9.4
    11: Paste image rename v1.6.1
    12: Settings Search v1.3.10
    13: Style Settings v1.0.7
    14: Templater v2.2.3
    15: Taskbone v2.3.0
    16: Git v2.24.0
    17: Better Daily Notes Plugin v0.3.3

It is not my plugins or settings because it happens in the sandbox vault as well with only Prism and Style Settings installed.

Additional context
Latest release, Obsidian disabled translucency for Windows due to an upstream Electron bug they are fixing and it seems like this "custom" color is trying to add that and breaking due to that not being an option anymore.

@DudeThatsErin DudeThatsErin added the Bug Something isn't working / doesn't look right label Mar 7, 2024
@damiankorcz
Copy link
Owner

Hi @DudeThatsErin,
The custom option in Color Schemes is intended to be used when you create your own Color Scheme. More info on that here:
https://github.com/damiankorcz/Prism-Theme/wiki/Creating-a-Custom-Colour-Scheme-CSS-Snippet

As to recovering your Vault back to normal:

  1. Turn off Obsidian.
  2. Navigate to your vault's main folder.
  3. In there go to: .obsidian/plugins/obsidian-style-settings/data.json
  4. Open the file and edit the following lines to match:
"obsidian-prism-theme@@color-schemes-lt": "pt-color-scheme-swan-lt",
"obsidian-prism-theme@@color-schemes-dt": "pt-color-scheme-raven-dt",
  1. Save the file and reopen your vault.

I'll see if I can make this less confusing in a future update.

damiankorcz added a commit that referenced this issue Mar 22, 2024
…e usable without the required user defined CSS snippet #158
@damiankorcz
Copy link
Owner

Hi @DudeThatsErin,
This issue should now be resolved in Prism 3.5.0.
I've made the custom option utilise the colours of the Swan and Raven Colour scheme for Light and Dark respectively; preventing the issue you had. This way you can still overwrite the colours but you don't end up with an unusable vault 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working / doesn't look right
Projects
None yet
Development

No branches or pull requests

2 participants