Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryFetch should not always use parseInt, should not string join to array #139

Open
jeffzyliu opened this issue Feb 27, 2023 · 3 comments
Assignees

Comments

@jeffzyliu
Copy link
Member

jeffzyliu commented Feb 27, 2023

add logic to search for a ., if so, parseFloat instead?

for array thing: we will update frontend to properly send an array of counties so we don't need to do string split anymore bc express and axios hadle that

@jeffzyliu jeffzyliu transferred this issue from dali-lab/pine-beetle-automation Feb 27, 2023
@jeffzyliu jeffzyliu self-assigned this Feb 28, 2023
@jeffzyliu
Copy link
Member Author

jeffzyliu commented Apr 13, 2023

@jeffzyliu
Copy link
Member Author

Also this should be removed/changed in general since https://windix.medium.com/parsing-array-from-get-parameters-in-node-js-express-ee03d8f2ddb1

@jeffzyliu
Copy link
Member Author

revision: specifyqueryfetch needs complete overhaul. queryfetch needs to know how to parseFloat.

@jeffzyliu jeffzyliu changed the title specifiedQueryFetch should not always use parseInt queryFetch should not always use parseInt Apr 13, 2023
@jeffzyliu jeffzyliu changed the title queryFetch should not always use parseInt queryFetch should not always use parseInt, should not string join to array Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant