Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byte-array encoding/decoding is not symetrical #143

Open
smessems opened this issue Jun 5, 2019 · 1 comment
Open

byte-array encoding/decoding is not symetrical #143

smessems opened this issue Jun 5, 2019 · 1 comment

Comments

@smessems
Copy link

smessems commented Jun 5, 2019

Hi, when encoding a byte-array, the internal call to writeBinary encodes it as base64.
However, the parse-string returns it as the encoded base64 string.
Maybe, this only needs to be documented, I am not sure.

The relevant test, uses threading-last instead of threading-first macro, hence the issue is not detected ( inside test-round-trip-binary ):

(= (->> bin-obj (get "byte-array") seq) (->> roundtripped (get "byte-array") seq)

@gfredericks
Copy link
Collaborator

I don't think this is solvable without the user having to give information to the parser about where the byte arrays are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants